PR #23301: fix(cli): guard _prompt_text_input against background-thread call to prevent RuntimeWarning

• Repository: NousResearch/hermes-agent
• Author: liuhao1024
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23301

Description (problem / solution / changelog)

Summary

_prompt_text_input calls run_in_terminal() which requires an asyncio event loop. When called from the process_loop daemon thread (e.g. during _confirm_destructive_slash for /clear or /new), the coroutine returned by run_in_terminal is never awaited, producing:

RuntimeWarning: coroutine 'run_in_terminal.<locals>.run' was never awaited

Root Cause

_prompt_text_input checks if self._app: and calls run_in_terminal(_ask), but does not verify whether it's running on the main prompt_toolkit thread. The process_loop background thread has self._app set (it's a shared attribute), so the run_in_terminal path is taken even when no event loop is available.

The sibling method _curses_single_select already handles this correctly with a threading.current_thread() is threading.main_thread() guard.

Fix

Add the same in_main_thread guard to _prompt_text_input: when running on a background thread, fall back to direct input() instead of run_in_terminal().

Regression Coverage

• test_prompt_text_input_skips_run_in_terminal_from_background_thread — verifies run_in_terminal is NOT called from a background thread
• test_prompt_text_input_uses_run_in_terminal_from_main_thread — verifies the normal prompt_toolkit path is still used from the main thread
• All 657 existing CLI tests pass (pre-existing ruamel import failure in test_cli_save_config_value.py is unrelated)

Testing

scripts/run_tests.sh tests/cli/test_prompt_text_input_thread_guard.py tests/cli/test_destructive_slash_confirm.py tests/hermes_cli/test_destructive_slash_confirm_gate.py

Fixes [Bug]: RuntimeWarning "run_in_terminal... was never awaited" when confirming /clear or /new in CLI #23297

Changed files

• cli.py (modified, +7/-1)
• tests/cli/test_prompt_text_input_thread_guard.py (added, +86/-0)

PR #23317: fix(cli): suppress RuntimeWarning from unawaited run_in_terminal in prompt_toolkit 3.0.52+

• Repository: NousResearch/hermes-agent
• Author: Ninso112
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23317

Description (problem / solution / changelog)

Summary

• Fixes RuntimeWarning: coroutine 'run_in_terminal.<locals>.run' was never awaited that appears when confirming /clear, /new, /reset, or /undo in the interactive CLI
• prompt_toolkit 3.0.52+ changed run_in_terminal() to return an Awaitable. Four call sites in cli.py invoke it fire-and-forget because the callback is scheduled on the already-running event loop and executes correctly
• Suppresses the warning at each call site with warnings.catch_warnings() since the callback semantics are unchanged

Affected call sites

Fixes #23297.

Changed files

• cli.py (modified, +27/-4)
• gateway/run.py (modified, +6/-9)