dify - ✅(Solved) Fix [Bug] Save button missing when adding LLM model type for GPUStack provider [1 pull requests, 4 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
langgenius/dify#35486Fetched 2026-04-23 07:45:29
View on GitHub
Comments
4
Participants
2
Timeline
10
Reactions
1
Author
Assignees
Timeline (top)
commented ×4assigned ×1closed ×1cross-referenced ×1

Fix Action

Fixed

PR fix notes

PR #35490: fix(web): keep Add model dialog footer visible when form overflows

Description (problem / solution / changelog)

Summary

  • The Add model dialog's Save/Add button and encryption notice were being clipped off-screen when the form grew tall (notably when selecting LLM model type, which renders more fields than Text Embedding or Rerank).
  • Root cause: DialogContent caps popup height at max-h-[80dvh], but the modal's inner scroll region sized itself against the full viewport (max-h-[calc(100vh-320px)]). Combined with overflow-hidden on the outer container, anything below the form got pushed past the 80dvh boundary and clipped.
  • Fix: switch the dialog to a flex column — header, footer button row, and encryption strip use shrink-0; the form region uses min-h-0 flex-1 overflow-y-auto so it absorbs the remaining space within the 80dvh budget.

Closes #35486 Closes #35423 Closes langgenius/dify-official-plugins#2923

Test plan

  • Existing model-modal unit tests pass (pnpm test app/components/header/account-setting/model-provider-page/model-modal/__tests__/index.spec.tsx)
  • Manually verify in-browser: Settings → Model Providers → add an OpenAI-API-compatible / GPUStack model with LLM type selected, confirm the Add button and PKCS1_OAEP notice are both visible without clipping
  • Verify with Text Embedding and Rerank types (regression check)
  • Verify at short viewport heights (e.g. 700–800px) that the inner form scrolls and the footer stays pinned

🤖 Generated with Claude Code

Changed files

  • web/app/components/header/account-setting/model-provider-page/model-modal/index.tsx (modified, +5/-5)
RAW_BUFFERClick to expand / collapse

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.13.3

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

Problem Description

When integrating GPUStack as a model provider in Dify, there is an abnormal behavior in the model addition interface:

  • When Model Type is set to LLM, the Save button does NOT appear at the bottom of the form, making it impossible to add the model.
  • When Model Type is set to Text Embedding or Rerank, the Add and Save buttons appear normally, and models can be added successfully.

Steps to Reproduce

  1. Navigate to Dify Admin Panel → Settings → Model Providers
  2. Find and click on the GPUStack provider
  3. Click Add Model
  4. In the Model Type dropdown:
    • Select Text Embedding or Rerank → Save button appears normally at the bottom
    • Select LLM → Save button is missing at the bottom
  5. Cannot complete the addition of LLM models

✔️ Expected Behavior

When selecting LLM model type, the Save button should appear normally at the bottom of the form, allowing users to save the model configuration.

❌ Actual Behavior

When selecting LLM model type, the Save button is missing, and the model cannot be saved.

extent analysis

TL;DR

The issue can be resolved by investigating and fixing the conditional rendering of the Save button in the model addition interface, specifically for the LLM model type.

Guidance

  • Verify the frontend code responsible for rendering the Save button to ensure it is not conditionally hidden based on the model type.
  • Check the CSS styles applied to the Save button to see if there are any model-type-specific rules that might be causing it to be hidden.
  • Inspect the JavaScript code that handles the model type selection to ensure it correctly updates the form state and triggers the necessary re-renders.
  • Test the model addition interface with different model types to confirm the issue is isolated to the LLM type.

Example

No code example can be provided without accessing the actual codebase, but the investigation should focus on the model type selection handler and the Save button's rendering logic.

Notes

The issue seems to be related to the specific model type LLM, and the fix will likely involve updating the frontend code to correctly handle this type.

Recommendation

Apply a workaround by temporarily modifying the frontend code to always render the Save button, regardless of the model type, to verify if the issue is indeed related to the conditional rendering.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING