PR #12853: fix(telegram): route model-picker thread_id through _message_thread_id_for_send

• Repository: NousResearch/hermes-agent
• Author: hclsys
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/12853

Description (problem / solution / changelog)

Problem

In Telegram forum groups with topics enabled, `/model` silently fell back to plain-text output instead of showing the interactive inline-keyboard picker. Reporter @wl-lgtm traced it (#12839) to `send_model_picker()` in `gateway/platforms/telegram.py`: it passes `message_thread_id=int(thread_id)` directly, skipping the `_message_thread_id_for_send()` helper that every other send method in the adapter uses. The helper converts the General-topic sentinel `"1"` to `None`; without it, Telegram sees `message_thread_id=1` (a non-existent topic) and rejects with "Message thread not found". The picker's try/except then logs a warning and the CLI falls back to text.

Fix

Swap the direct `int(thread_id) if thread_id else None` for the existing `self._message_thread_id_for_send(thread_id)` helper. Thirteen other call sites in this file already use it (send_text, send_photo, send_animation, voice, audio, etc.), so this just brings the picker in line.

Pre-implement audit

• A (existing helper): `_message_thread_id_for_send` defined at line 269, already imported and used in 13 other call sites. Reuse.
• B (shared callers): The helper is a classmethod; contract is preserved — this PR only adds a 14th call site, no signature change.
• C (broader rival): No rival PR for #12839. `gh pr list --search "send_model_picker"` returns only historical unrelated commits.

Testing

New `tests/gateway/test_telegram_model_picker_thread.py`:

• `test_send_model_picker_normalizes_general_topic_sentinel_to_none` — asserts that `metadata={"thread_id": "1"}` results in `send_message(..., message_thread_id=None, ...)`.
• `test_send_model_picker_passes_real_thread_id_through` — asserts `"42"` stays `42` (no over-correction).

Both pass locally (2/2).

Fixes #12839

Changed files

• gateway/platforms/telegram.py (modified, +5/-1)
• tests/gateway/test_telegram_model_picker_thread.py (added, +136/-0)

---

PR #12856: fix(telegram): use _message_thread_id_for_send in send_model_picker

• Repository: NousResearch/hermes-agent
• Author: kagura-agent
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/12856

Description (problem / solution / changelog)

Fix

Closes #12839

send_model_picker was using int(thread_id) if thread_id else None directly instead of self._message_thread_id_for_send(thread_id), which all other send methods use. This caused:

• General topic (thread_id="1") to pass message_thread_id=1 instead of None, triggering 'Message thread not found' errors
• The picker to fall back to plain text output in forum groups

Changes

• gateway/platforms/telegram.py: Replace inline thread_id logic with self._message_thread_id_for_send(thread_id) in send_model_picker
• Tests: 3 new tests covering normal topics, General topic mapping, and no-thread scenarios

Changed files

• gateway/platforms/telegram.py (modified, +1/-1)
• tests/gateway/test_telegram_thread_fallback.py (modified, +96/-3)

---

PR #12873: fix: use _message_thread_id_for_send() in send_model_picker() for forum topics

• Repository: NousResearch/hermes-agent
• Author: ztexydt-cqh
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/12873

Description (problem / solution / changelog)

Problem

In send_model_picker(), the code directly read metadata.get("thread_id") and passed int(thread_id) as message_thread_id to send_message(). This bypassed _message_thread_id_for_send(), which contains special handling for Telegram forum General topics (thread_id == "1" should be sent as None). As a result, sending the model picker in a forum General topic caused Telegram to return "Message thread not found".

Solution

Replace the raw metadata access with self._metadata_thread_id(metadata) and use self._message_thread_id_for_send(thread_id) when calling send_message(). This aligns send_model_picker() with all other send methods in the adapter, ensuring consistent forum topic handling.

Verification

• Code review confirmed the two-line change matches the pattern already used in send(), send_exec_approval(), and send_typing().
• No other callers of send_message() in the adapter bypass _message_thread_id_for_send().

Closes #12839.

Changed files

• gateway/platforms/telegram.py (modified, +2/-2)