openclaw - 💡(How to fix) Fix [Bug]: Session store saves run preserve scans below maintenance thresholds [4 pull requests]

Bug type

Behavior bug (incorrect output/state without crash)

Beta release blocker

No

Summary

Session store saves call maintenance preserve providers even when entry maintenance does not need provider state, triggering expensive subagent registry reads on ordinary writes.

Steps to reproduce

1. Run a long-lived OpenClaw gateway workload with active session, subagent, and plugin metadata traffic.
2. Capture a CPU profile and diagnostics timeline.
3. Inspect the profile/timeline for the call chain described in the evidence below.

Expected behavior

Save-side maintenance should collect preserve keys only when stale pruning, cap maintenance, or disk-budget enforcement needs those keys, while preserving existing stale-prune behavior.

Actual behavior

Profile evidence showed saveSessionStoreUnlocked flowing into collectSessionMaintenancePreserveKeys, listSessionMaintenanceProtectedSubagentSessionKeys, getSubagentRunsSnapshotForRead, and clone-heavy subagent registry reads.

OpenClaw version

Current main source checkout before the linked fix branch; exact release build is NOT_ENOUGH_INFO.

Operating system

NOT_ENOUGH_INFO

Install method

Source checkout / development workflow.

Model

NOT_ENOUGH_INFO

Provider / routing chain

NOT_ENOUGH_INFO

Additional provider/model setup details

Not model-specific; this is a gateway/session/plugin hot-path performance issue.

Logs, screenshots, and evidence

Profile excerpt showed saveSessionStoreUnlocked at 1571.64s inclusive and collectSessionMaintenancePreserveKeys at 1423.20s inclusive, flowing into subagent registry snapshot cloning.

Impact and severity

Affected: session store writes, agent run persistence, and metadata updates. Severity: Medium-High. Frequency: repeated saves in the captured profile. Consequence: avoidable registry reads and clone/GC work during ordinary persistence.

Additional information

Public issue extracted from local redacted performance evidence under /mnt/c/OpenClaw/bugs/BUG-042-session-store-saves-perform-full-maintenance-preserve-scans-and-whole-store-snapshot-clone. Private session labels, transcript paths, setup names, and raw local paths were not included.