PR #59217: fix(approvals): use canonical decision values in interactive button payloads

• Repository: openclaw/openclaw
• Author: jameslcowan
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/59217

Description (problem / solution / changelog)

Summary

• buildExecApprovalCommandText was converting allow-always to the shorter alias always in button payloads. On Slack, interactive button values bypass the text command parser's DECISION_ALIASES mapping, so the raw always value reaches the approval resolver instead of the expected allow-always. This causes approvals not to persist and leads to repeated prompts.
• The fix uses canonical decision values (allow-always) directly in button payloads, eliminating the alias indirection. The text command parser still accepts both always and allow-always, so text-based approvals remain backward compatible.
• Note: Telegram's standalone buildTelegramExecApprovalButtons in approval-buttons.ts intentionally retains the shorter always alias to stay within Telegram's 64-byte callback_data limit. Telegram's parser handles the alias translation correctly.

Closes #59091

Test plan

• exec-approval-reply.test.ts (8 tests pass)
• exec-approval-forwarder.test.ts (updated button value expectations)
• plugin-approval-forwarder.test.ts (updated button value expectations)
• approval-renderers.test.ts (updated button value expectations)
• exec-approvals-handler.test.ts (Telegram handler, updated expectations)
• inline-buttons.test.ts (Telegram standalone buttons, unchanged -- intentionally uses alias)

Changed files

• extensions/telegram/src/exec-approvals-handler.test.ts (modified, +1/-1)
• src/infra/exec-approval-forwarder.test.ts (modified, +3/-3)
• src/infra/exec-approval-reply.test.ts (modified, +4/-4)
• src/infra/exec-approval-reply.ts (modified, +1/-1)
• src/infra/plugin-approval-forwarder.test.ts (modified, +1/-1)
• src/plugin-sdk/approval-renderers.test.ts (modified, +2/-2)