PR #54924: fix: flush draft stream before reading messageId to prevent double Slack messages

• Repository: openclaw/openclaw
• Author: arkyu2077
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54924

Description (problem / solution / changelog)

Fixes #54857

Problem

Fast LLM responses complete before the Slack stream throttle (1000ms) fires. deliver() reads draftMessageId as undefined, falls through to deliverNormally(), and posts a duplicate message.

Fix

Flush the pending draft synchronously before reading draftMessageId:

if (hasStreamedMessage && draftStream && !draftStream.messageId()) await draftStream.flush();
const draftMessageId = draftStream?.messageId();

Impact

Eliminates double messages in Slack for fast/short responses. No change for longer responses where throttle already fires before delivery.

Changed files

• extensions/slack/src/monitor/message-handler/dispatch.ts (modified, +3/-0)

PR #54937: fix(slack): flush draft before reading messageId to prevent double messages on fast responses

• Repository: openclaw/openclaw
• Author: lyfuci
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54937

Description (problem / solution / changelog)

Summary

When an LLM responds faster than the 1000ms Slack draft-stream throttle, messageId() returns undefined at the time deliver() is called. This causes canFinalizeViaPreviewEdit to evaluate to false, so the code falls through to deliverNormally() and posts a second independent message. The draft-stream throttle then fires shortly after, posting the original draft — resulting in two visible Slack messages.

Root Cause

In extensions/slack/src/monitor/message-handler/dispatch.ts, draftMessageId was read before any pending draft update had been flushed:

// Before fix — messageId() is undefined if throttle hasn't fired yet
const draftMessageId = draftStream?.messageId();

Fix

Call draftStream.flush() before reading messageId(). flush() cancels the pending timer and synchronously sends the queued draft text, guaranteeing messageId() is populated when preview streaming is active.

// After fix
await draftStream?.flush();
const draftMessageId = draftStream?.messageId();

Testing

Added a regression test in extensions/slack/src/draft-stream.test.ts asserting that messageId() is undefined before flush() and non-undefined after — directly validating the guarantee the fix relies on.

Fixes openclaw/openclaw#54857

AI Assistance

• AI-assisted (Claude Sonnet 4.6 via OpenClaw)
• Lightly tested — pnpm check (lint, format, type checks, boundary checks) passed; targeted unit tests added/verified
• Full pnpm build && pnpm test not run (CI will validate)
• Code reviewed and understood by human author
• Codex review not run locally; CI Codex review will apply

Extension test results

pnpm test:extension slack: 57 test files, 451 tests — all passed ✅

Changed files

• extensions/slack/src/draft-stream.test.ts (modified, +12/-0)
• extensions/slack/src/monitor/message-handler/dispatch.ts (modified, +10/-0)