Issue Station
Sign In
Tools hereToolbox

openclaw - 💡(How to fix) Fix [Bug]: Subagent run-manager catch {} ignores completeSubagentRun failure [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

In src/agents/subagent-registry-run-manager.ts:232-244, after persist() records the run as ended, completeSubagentRun attempts the farewell message and cleanup. If it throws, bare catch { // ignore } drops both the farewell and cleanup silently.

Error Message

Log the error and/or schedule retry for farewell delivery, consistent with the error handling pattern in PR #82943.

Root Cause

In src/agents/subagent-registry-run-manager.ts:232-244, after persist() records the run as ended, completeSubagentRun attempts the farewell message and cleanup. If it throws, bare catch { // ignore } drops both the farewell and cleanup silently.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Summary

In src/agents/subagent-registry-run-manager.ts:232-244, after persist() records the run as ended, completeSubagentRun attempts the farewell message and cleanup. If it throws, bare catch { // ignore } drops both the farewell and cleanup silently.

Impact

The run is permanently marked as ended but the farewell message and cleanup are lost. The parent session never receives the subagent completion signal. Same bug family as F002/F003 (subagent lifecycle fire-and-forget).

Suggested fix

Log the error and/or schedule retry for farewell delivery, consistent with the error handling pattern in PR #82943.

Found by

Codebase audit (finding F021).

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#environment setup#docker error#permission error#memory optimization#batch processing

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING