PR #54403: fix: rebuild subsystem file logger on date rollover

• Repository: openclaw/openclaw
• Author: ikebo
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54403

Description (problem / solution / changelog)

Summary

• Problem: createSubsystemLogger caches the file logger on first use and never rebuilds it. When the gateway runs past midnight, logs continue writing to the previous day's file instead of the new dated file.
• Why it matters: Long-running gateway processes (the common deployment) silently write all logs to a stale file, breaking log rotation and making daily log analysis unreliable.
• What changed: getFileLogger() now compares the current base logger reference (from getLogger()) against the cached one. When the base logger changes (due to date rollover or any settings change), the child logger is rebuilt. getLogger() is already cheaply cached internally, so this adds only a reference equality check on the hot path.
• What did NOT change: No changes to log format, file naming, or any other logging behavior.

Change Type (select all)

• Bug fix

Scope (select all touched areas)

• Gateway / orchestration

Test plan

• Added test in subsystem.test.ts that simulates date rollover via resetLogger() and verifies the base logger instance changes

Closes #54381

Changed files

• src/logging/subsystem.test.ts (modified, +22/-1)
• src/logging/subsystem.ts (modified, +9/-2)

PR #54527: fix(logging): rebuild subsystem file logger on date rollover

• Repository: openclaw/openclaw
• Author: cgdusek
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54527

Description (problem / solution / changelog)

Summary

• Fix: Subsystem loggers cached their tslog file logger child on first use and never rebuilt it. Long-running gateways writing logs past midnight continued using the previous day's file, breaking log rotation.
• Approach: Replace the forever-cache with a midnight-aware cache — compare Date.now() against the next local midnight timestamp on each file log call. After midnight, rebuild the child logger from the current root logger.
• Hot-path cost: Essentially zero — just Date.now() (no allocation) + integer comparison. The child logger is only rebuilt once per day.

Why this approach

This bug has attracted 19+ prior PRs (all closed or review-blocked). The two recurring problems:

1. Hot-path cost — PR #54403 and others called getLogger() → resolveSettings() on every log emit, which can reach readLoggingConfig() and dynamic require() on each call.
2. Weak tests — Tests only verified getLogger() returns a new instance after resetLogger(), which is a tautology. None verified the subsystem child was actually rebuilt.

This PR avoids both:

• Hot path is Date.now() + integer comparison (~free)
• Tests spy on getChildLogger and verify it's called exactly twice (initial + post-rollover), and only once for same-day repeated logging

Test plan

• pnpm test -- src/logging/subsystem.test.ts — 13/13 passed (2 new tests)
• pnpm check — clean
• pnpm tsgo — clean
• pnpm build — clean

Closes #54381

🤖 Generated with Claude Code

Changed files

• src/logging/subsystem.test.ts (modified, +43/-0)
• src/logging/subsystem.ts (modified, +13/-2)

PR #54589: fix(logger): re-create file logger after midnight to use correct dated log file

• Repository: openclaw/openclaw
• Author: reed1898
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/54589

Description (problem / solution / changelog)

Summary

Fixes #54381

The subsystem logger cached the file logger on first call, so after midnight new log entries continued to be written to the previous day's file.

Root Cause

In createSubsystemLogger, getFileLogger stored the logger in a closure variable (fileLogger) and only created it once (if (!fileLogger)). Since the underlying logger uses a date-stamped filename, the cached logger kept pointing to yesterday's file.

Fix

Added a fileLoggerDate string that records the date (Date.toDateString()) when the logger was last created. On every call, getFileLogger compares the current date to the cached date and re-creates the logger when they differ.

// Before
if (!fileLogger) {
  fileLogger = getChildLogger({ subsystem });
}

// After
const today = new Date().toDateString();
if (!fileLogger || fileLoggerDate !== today) {
  fileLogger = getChildLogger({ subsystem });
  fileLoggerDate = today;
}

Test

Added a test in src/logging/subsystem.test.ts using vi.useFakeTimers() that simulates a midnight crossing and verifies the logger is re-created exactly once after the date changes.

Changed files

• src/logging/subsystem.test.ts (modified, +40/-0)
• src/logging/subsystem.ts (modified, +4/-1)