openclaw - 💡(How to fix) Fix Bug: task-registry-import-boundary test fails after #58828 added commands-tasks.ts [2 comments, 1 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
openclaw/openclaw#58888Fetched 2026-04-08 02:31:29
View on GitHub
Comments
2
Participants
1
Timeline
3
Reactions
0
Participants
Timeline (top)
closed ×1commented ×1locked ×1

src/tasks/task-registry-import-boundary.test.ts fails on all branches that merge current main. The test enforces an allowlist of files permitted to import task-registry.js, but PR #58828 (feat(tasks): add chat-native task board) introduced auto-reply/reply/commands-tasks.ts which imports task-registry.js without updating the allowlist.

Error Message

AssertionError: expected [ …(4) ] to deeply equal [ …(3) ]

- Expected
+ Received

  [
    "auto-reply/reply/commands-status.ts",
+   "auto-reply/reply/commands-tasks.ts",
    "tasks/runtime-internal.ts",
    "tasks/task-owner-access.ts",
  ]

Root Cause

src/tasks/task-registry-import-boundary.test.ts fails on all branches that merge current main. The test enforces an allowlist of files permitted to import task-registry.js, but PR #58828 (feat(tasks): add chat-native task board) introduced auto-reply/reply/commands-tasks.ts which imports task-registry.js without updating the allowlist.

Code Example

AssertionError: expected [ (4) ] to deeply equal [ (3) ]

- Expected
+ Received

  [
    "auto-reply/reply/commands-status.ts",
+   "auto-reply/reply/commands-tasks.ts",
    "tasks/runtime-internal.ts",
    "tasks/task-owner-access.ts",
  ]

---

const ALLOWED_IMPORTERS = new Set([
  "auto-reply/reply/commands-status.ts",
  "auto-reply/reply/commands-tasks.ts",  // added by #58828
  "tasks/runtime-internal.ts",
  "tasks/task-owner-access.ts",
]);
RAW_BUFFERClick to expand / collapse

Description

src/tasks/task-registry-import-boundary.test.ts fails on all branches that merge current main. The test enforces an allowlist of files permitted to import task-registry.js, but PR #58828 (feat(tasks): add chat-native task board) introduced auto-reply/reply/commands-tasks.ts which imports task-registry.js without updating the allowlist.

Failing checks

This causes failures in checks-node-test-2, checks-node-test-4, checks-windows-node-test-1, checks-windows-node-test-2, checks-windows-node-test-4, and checks-windows-node-test-6 across multiple PRs.

Error

AssertionError: expected [ …(4) ] to deeply equal [ …(3) ]

- Expected
+ Received

  [
    "auto-reply/reply/commands-status.ts",
+   "auto-reply/reply/commands-tasks.ts",
    "tasks/runtime-internal.ts",
    "tasks/task-owner-access.ts",
  ]

Suggested fix

Add "auto-reply/reply/commands-tasks.ts" to the ALLOWED_IMPORTERS set in src/tasks/task-registry-import-boundary.test.ts:

const ALLOWED_IMPORTERS = new Set([
  "auto-reply/reply/commands-status.ts",
  "auto-reply/reply/commands-tasks.ts",  // added by #58828
  "tasks/runtime-internal.ts",
  "tasks/task-owner-access.ts",
]);

Introduced by

Commit facdeb3432 (PR #58828)

extent analysis

TL;DR

Add "auto-reply/reply/commands-tasks.ts" to the ALLOWED_IMPORTERS set in src/tasks/task-registry-import-boundary.test.ts to resolve the test failure.

Guidance

  • Update the ALLOWED_IMPORTERS set in src/tasks/task-registry-import-boundary.test.ts with the new file "auto-reply/reply/commands-tasks.ts" to reflect the changes introduced by PR #58828.
  • Verify that the test src/tasks/task-registry-import-boundary.test.ts passes after updating the ALLOWED_IMPORTERS set.
  • Check other tests and code areas that might be affected by the introduction of auto-reply/reply/commands-tasks.ts to ensure no other issues are introduced.
  • Review commit facdeb3432 (PR #58828) to understand the context and reasoning behind the addition of auto-reply/reply/commands-tasks.ts.

Example

The suggested fix is already provided in the issue:

const ALLOWED_IMPORTERS = new Set([
  "auto-reply/reply/commands-status.ts",
  "auto-reply/reply/commands-tasks.ts",  // added by #58828
  "tasks/runtime-internal.ts",
  "tasks/task-owner-access.ts",
]);

Notes

This fix assumes that the introduction of auto-reply/reply/commands-tasks.ts is intended and correct. If this file should not import task-registry.js, further investigation is needed.

Recommendation

Apply the suggested workaround by adding "auto-reply/reply/commands-tasks.ts" to the ALLOWED_IMPORTERS set, as it directly addresses the test failure caused by PR #58828.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

openclaw - 💡(How to fix) Fix Bug: task-registry-import-boundary test fails after #58828 added commands-tasks.ts [2 comments, 1 participants]