PR #59776: fix: decouple approval availability from native delivery enablement

• Repository: openclaw/openclaw
• Author: joelnishanth
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/59776

Description (problem / solution / changelog)

Summary

Fixes #59620.

getActionAvailabilityState in createApproverRestrictedNativeApprovalAdapter was gating on both hasApprovers and isNativeDeliveryEnabled. This caused Telegram exec approvals to report "approvals not allowed on this platform" when channels.telegram.execApprovals.target was configured (e.g. "dm", "channel", or "both") but execApprovals.enabled was not explicitly true.

Root cause

The regression was introduced in v2026.4.1 during the approval capability refactor. The availability check should only depend on whether approvers exist — native delivery mode (dm/channel/both) is a routing concern handled downstream in resolveChannelNativeApprovalDeliveryPlan, not a gating condition for the approval surface itself.

Changes

• src/plugin-sdk/approval-delivery-helpers.ts: Remove the isNativeDeliveryEnabled guard from getActionAvailabilityState so the approval surface reports kind: "enabled" whenever approvers are configured, regardless of the native delivery toggle.
• src/plugin-sdk/approval-delivery-helpers.test.ts: Add a dedicated regression test that validates getActionAvailabilityState returns kind: "enabled" when approvers exist but native delivery is off, and update the existing assertion that was masking the bug.

Test plan

• npx vitest run src/plugin-sdk/approval-delivery-helpers.test.ts — 5/5 pass (including new regression test)
• npx vitest run src/infra/exec-approval-surface.test.ts — 11/11 pass
• npx vitest run src/infra/approval-turn-source.test.ts — 3/3 pass
• Oxlint clean on both changed files

— Joel Nishanth · offlyn.AI

Made with Cursor

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/discord/src/approval-native.test.ts (modified, +41/-0)
• extensions/slack/src/approval-native.test.ts (modified, +43/-0)
• src/plugin-sdk/approval-delivery-helpers.test.ts (modified, +25/-1)
• src/plugin-sdk/approval-delivery-helpers.ts (modified, +1/-1)