PR #73534: fix(telegram): scope native quote streaming guard to real quotes (#73505)

• Repository: openclaw/openclaw
• Author: hclsys
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73534

Description (problem / solution / changelog)

What

Fixes #73505. When channels.telegram.replyToMode is set to anything other than "off", partial-stream preview is silently disabled for plain replies even though editMessageText round-trips with reply_to_message_id unchanged. The result is that operators with replyToMode: "first" see no streaming preview at all — text appears only after the run completes.

Root cause

bot-message-dispatch.ts builds a replyQuoteByMessageId map for native-quote candidate lookups during delivery, then computes:

const hasNativeQuoteReply =
  replyToMode !== "off" && Object.keys(replyQuoteByMessageId).length > 0;

Under replyToMode !== "off" the dispatcher unconditionally calls addTelegramNativeQuoteCandidate(replyQuoteByMessageId, ctxPayload.MessageSid ?? msg.message_id, ...) for the inbound message itself, so any inbound message with text populates the map and trips hasNativeQuoteReply → canStreamAnswerDraft = false → no preview lane.

The reason streaming is incompatible with native quote replies is the Telegram quote parameter, which editMessageText cannot re-send. Plain reply_to_message_id (no quote) does not have that constraint — and the dispatcher already passes draftReplyToMessageId into createTelegramDraftStream, which means the rest of the codepath is built to handle this case.

Fix

Tighten the guard to require an actual user-selected quote, matching the same replyQuoteText && replyQuoteMessageId != null pattern already used a few lines above to gate addTelegramNativeQuoteCandidate for explicit reply targets:

const hasNativeQuoteReply =
  replyToMode !== "off" && replyQuoteText != null && replyQuoteMessageId != null;

replyQuoteText is only set when ctxPayload.ReplyToIsQuote is true, and replyQuoteMessageId is only set when that quote points at a non-external resolvable message. Together they describe the only case where streaming truly cannot work.

Behavior preserved

• Quote-bearing replies (ReplyToIsQuote=true with text + resolvable id) still take the non-streaming path — covered by the existing skips answer draft preview for same-chat selected quotes test.
• replyQuoteByMessageId is still passed verbatim to deliverReplies for fallback handling — covered by the existing passes native quote candidates for current message replies and passes native quote candidates for explicit reply targets tests, which still assert the same map payload.

Test changes

• passes native quote candidates for current message replies — flipped from asserting createTelegramDraftStream is NOT called to asserting it IS called. The map-payload assertion is unchanged: candidates are still attached for the eventual final delivery.
• New regression test keeps answer draft preview for plain replies in groups with replyToMode set — pins #73505 behavior directly with replyToMode: "first" + streamMode: "partial" + plain inbound message → expects createTelegramDraftStream and draftStream.update("Hello").

Verified locally

npx oxlint extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts
# Found 0 warnings and 0 errors.

npx vitest run extensions/telegram/src/bot-message-dispatch.test.ts
# Tests  109 passed (109)

npx vitest run extensions/telegram/src/bot/delivery.test.ts
# Tests  41 passed (41)

lobster-biscuit: 73505-replytomode-streaming-guard

Sign-Off:

• I have read and agree to the OpenClaw Contributor License Agreement.

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/telegram/src/bot-message-dispatch.test.ts (modified, +45/-1)
• extensions/telegram/src/bot-message-dispatch.ts (modified, +9/-1)

PR #39905: feat(telegram): scope reply and streaming settings per conversation

• Repository: openclaw/openclaw
• Author: huangkefeng-ai
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/39905

Description (problem / solution / changelog)

Summary

Describe the problem and fix in 2–5 bullets:

• Problem: Telegram replyToMode and preview streaming were effectively account-wide defaults, so direct chats, groups, and topics could not choose different reply styles.
• Why it matters: some users want quoted live replies, others want plain 1:1 live replies, and Telegram quoted streaming must not regress into the old preview-message + final-message + delete-preview behavior.
• What changed: added Telegram replyToMode and streaming overrides to direct, groups, and topics; resolved those settings per conversation before dispatch; applied the same reply-threading override to native command replies; documented the new config surface.
• What did NOT change (scope boundary): this PR does not add command-based preference persistence, UI controls, or non-Telegram channel changes.

Change Type (select all)

• Bug fix
• Feature
• Refactor
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #
• Related #39880

User-visible / Behavior Changes

• Telegram now accepts conversation-scoped replyToMode overrides under:
  • channels.telegram.direct.<id>.replyToMode
  • channels.telegram.groups.<id>.replyToMode
  • channels.telegram.groups.<id>.topics.<threadId>.replyToMode
  • channels.telegram.direct.<id>.topics.<threadId>.replyToMode
• Telegram now accepts conversation-scoped preview streaming overrides under the matching direct/group/topic scopes.
• Telegram auto replies now resolve quoted-vs-non-quoted behavior per conversation instead of forcing one account-wide default.
• Telegram native command replies now honor the same per-conversation reply threading override.
• Quoted DM live streaming stays attached to one reply message instead of creating a temporary preview message, then sending a second final message, then deleting the first one.

Security Impact (required)

• New permissions/capabilities? (Yes/No) No
• Secrets/tokens handling changed? (Yes/No) No
• New/changed network calls? (Yes/No) No
• Command/tool execution surface changed? (Yes/No) No
• Data access scope changed? (Yes/No) No
• If any Yes, explain risk + mitigation:

Repro + Verification

Environment

• OS: Ubuntu on WSL2
• Runtime/container: local Node/pnpm workspace
• Model/provider: N/A (unit/integration-style Telegram channel tests)
• Integration/channel (if any): Telegram
• Relevant config (redacted): account-level channels.telegram.replyToMode/streaming plus scoped overrides under direct, groups, and topics

Steps

1. Configure Telegram account defaults with quoted replies and live preview enabled.
2. Add scoped overrides for one DM / one group / one topic with different replyToMode or streaming values.
3. Send Telegram replies through the message processor and native command path.
4. Exercise quoted DM preview streaming.

Expected

• Scoped overrides win over account defaults for the targeted DM/group/topic.
• Quoted DM live preview stays in a single reply message and does not create a second final message.

Actual

• Before this change, Telegram always used account-level replyToMode / streaming defaults.
• Before this change, quoted DM live preview could materialize as a temporary streamed message plus a second final reply.

Evidence

Attach at least one:

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

• Verified scenarios:
  • pnpm vitest run src/telegram/bot.helpers.test.ts src/telegram/bot-message.test.ts src/telegram/draft-stream.test.ts src/telegram/bot-message-dispatch.test.ts
  • pnpm vitest run src/telegram/bot-native-commands.test.ts src/telegram/bot-native-commands.group-auth.test.ts src/telegram/bot-native-commands.plugin-auth.test.ts src/telegram/bot-native-commands.session-meta.test.ts src/telegram/bot-native-commands.skills-allowlist.test.ts
  • confirmed processor-level scoped overrides for DM and topic/group paths via updated unit tests
  • confirmed quoted DM preview streaming path still stays on one reply message via existing draft-stream coverage in this branch
• Edge cases checked:
  • topic override precedence over group/account defaults
  • legacy scoped streamMode still resolves correctly
  • native command replies follow scoped replyToMode
• What you did not verify:
  • live manual Telegram traffic against the real Bot API from this source checkout
  • non-Telegram channels

Compatibility / Migration

• Backward compatible? (Yes/No) Yes
• Config/env changes? (Yes/No) No
• Migration needed? (Yes/No) No
• If yes, exact upgrade steps:

Failure Recovery (if this breaks)

• How to disable/revert this change quickly:
  • remove the scoped Telegram overrides and fall back to account-level channels.telegram.replyToMode / channels.telegram.streaming
  • revert commits 417217f8d2 and 45cba36cdf
• Files/config to restore:
  • src/telegram/bot-message.ts
  • src/telegram/bot-native-commands.ts
  • src/telegram/bot/helpers.ts
  • src/config/types.telegram.ts
  • src/config/zod-schema.providers-core.ts
• Known bad symptoms reviewers should watch for:
  • scoped DM/group/topic reply settings appear ignored
  • quoted Telegram streaming creates two messages or deletes the streamed preview after final delivery

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

• Risk: scoped override precedence could diverge between normal replies and native command replies.
  • Mitigation: both paths now use the same helper-based reply mode resolution, with tests covering processor dispatch and native command delivery.
• Risk: quoted DM streaming could regress back to preview/final double delivery when scoped overrides are enabled.
  • Mitigation: this branch includes the quoted DM single-message preview fix and keeps the dedicated draft-stream test coverage green.

Changed files

• .secrets.baseline (modified, +11/-11)
• docs/channels/telegram.md (modified, +17/-1)
• docs/gateway/configuration-reference.md (modified, +11/-0)
• src/cli/daemon-cli/lifecycle.test.ts (modified, +10/-11)
• src/config/types.telegram.ts (modified, +18/-0)
• src/config/zod-schema.providers-core.ts (modified, +9/-0)
• src/secrets/runtime.test.ts (modified, +12/-2)
• src/telegram/bot-message-dispatch.test.ts (modified, +72/-3)
• src/telegram/bot-message.test.ts (modified, +49/-1)
• src/telegram/bot-message.ts (modified, +25/-2)
• src/telegram/bot-native-commands.ts (modified, +28/-5)
• src/telegram/bot.helpers.test.ts (modified, +41/-1)
• src/telegram/bot/helpers.ts (modified, +30/-0)