PR #14035: fix(gateway): preserve legacy /voice off suppression across #12542 migration

• Repository: NousResearch/hermes-agent
• Author: season179
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/14035

Description (problem / solution / changelog)

Summary

Fixes #14025.

• Preserve legacy unprefixed "<chat_id>": "off" rows in gateway_voice_mode.json on load so auto-TTS suppression survives the #12542 platform-namespacing migration. Legacy voice_only / all rows continue to be dropped — migrating them without knowing the owning platform could fire TTS on a platform the user never configured.
• In _sync_voice_mode_state_to_adapter, make explicit <platform>:<chat_id> entries take precedence over legacy fallback rows for the same chat id on that platform, regardless of the explicit mode. Without this, a user who ran /voice on on a chat that had a legacy off row would get silently re-suppressed on the next restart — the same two-store drift as #14025 in the opposite direction.

Reproduction (before fix)

1. On a pre-#12542 build, run /voice off in a Telegram DM so gateway_voice_mode.json contains {"<telegram_chat_id>": "off"}.
2. Upgrade to a build containing 52a972e9 (#12542). Restart.
3. Send a voice message in that DM. Hermes sends one unwanted TTS reply because _auto_tts_disabled_chats was never rebuilt from the dropped legacy row, even though /voice status still reports off.

After fix

• Startup load preserves {"<chat_id>": "off"} and logs one info line explaining the preservation.
• Adapter sync applies the legacy off as a cross-platform fallback → _auto_tts_disabled_chats contains the chat id → the auto-TTS gate at gateway/platforms/base.py:1879 correctly suppresses.
• When the user later runs /voice on|tts on any platform, a prefixed row is written. On the next restart the precedence rule ensures the explicit row wins for that platform; the legacy row continues to act as a fallback for platforms that have not yet been explicitly reconfigured.

Test plan

New tests in tests/gateway/test_voice_mode_platform_isolation.py:

• test_load_voice_modes_preserves_legacy_off_keys — legacy off preserved, legacy all/voice_only dropped.
• test_sync_legacy_off_applies_to_all_adapters — legacy off suppresses auto-TTS on every adapter that has no explicit prefixed row for the same chat id.
• test_explicit_prefixed_state_overrides_legacy_off_on_same_platform — explicit prefixed rows (covering voice_only, all, and off) win over legacy fallback for the same chat id on the same platform; legacy fallback still applies to platforms that have no explicit row for that id.
• test_legacy_off_survives_upgrade_restart_for_telegram — end-to-end regression for the exact repro from the issue.

Renamed and tightened test_load_voice_modes_skips_legacy_keys → test_load_voice_modes_skips_legacy_nonoff_keys to reflect the new preservation behavior for off.

New test in tests/gateway/test_voice_command.py:

• test_voice_on_after_legacy_off_overrides_fallback_after_restart — full lifecycle through the real _handle_voice_command / _save_voice_modes / reload / sync chain, asserts no split-brain where /voice status reports on while auto-TTS stays suppressed.

All voice-mode tests pass: pytest tests/gateway/test_voice_mode_platform_isolation.py tests/gateway/test_voice_command.py — 164 passed, 21 skipped.

Changed files

• gateway/run.py (modified, +38/-12)
• tests/gateway/test_voice_command.py (modified, +29/-0)
• tests/gateway/test_voice_mode_platform_isolation.py (modified, +99/-8)

PR #14412: fix(gateway): preserve legacy voice off suppression

• Repository: NousResearch/hermes-agent
• Author: sgaofen
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/14412

Description (problem / solution / changelog)

Summary

Fixes #14025.

This preserves legacy /voice off auto-TTS suppression after the platform-key migration without reintroducing cross-platform voice-mode collisions.

Root cause

After #12542, _load_voice_modes() skipped all legacy unprefixed voice-mode keys. That was safe for old all / voice_only entries because enabling voice for an unknown platform can collide, but it also dropped old off entries. Since adapter auto-TTS suppression is rebuilt only from persisted off state, a Telegram chat that had /voice off before upgrade could receive one unwanted voice reply until /voice off was run again.

Fix

• Preserve legacy unprefixed off entries as internal legacy:<chat_id> suppression markers.
• Continue skipping legacy unprefixed all and voice_only entries.
• During adapter sync, apply legacy suppression only when that platform does not already have an explicit platform-prefixed state for the chat.
• Add regressions for legacy off loading, runtime suppression restore, and platform-specific override behavior.

Validation

• /Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_voice_mode_platform_isolation.py::TestLegacyKeyMigration::test_load_voice_modes_preserves_legacy_off_only tests/gateway/test_voice_mode_platform_isolation.py::TestSyncVoiceModeStateToAdapter::test_sync_restores_legacy_off_for_any_platform tests/gateway/test_voice_mode_platform_isolation.py::TestSyncVoiceModeStateToAdapter::test_sync_platform_state_overrides_legacy_off tests/gateway/test_voice_command.py::TestHandleVoiceCommand::test_restart_restores_voice_off_state -q --tb=short
• /Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_voice_mode_platform_isolation.py tests/gateway/test_voice_command.py -q --tb=short
• git diff --check

Changed files

• gateway/run.py (modified, +29/-3)
• tests/gateway/test_voice_mode_platform_isolation.py (modified, +37/-4)