PR #15246: test(model-switch): assert fetch_api_models kwargs match current signature (#15243)

• Repository: NousResearch/hermes-agent
• Author: briandevans
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/15246

Description (problem / solution / changelog)

What does this PR do?

Fixes `#15243`.

`_model_flow_named_custom` was extended in `647900e8` ("fix(cli): support model validation for anthropic_messages and cloudflare-protected endpoints") to pass `api_mode` through to `fetch_api_models` so Anthropic-messages and Cloudflare-protected endpoints validate correctly. The test that pins "we must still probe the endpoint when a model is already saved" was never updated for that new kwarg and has been failing on every PR's `test` CI lane since — it's one of the four standing baseline failures I've been calling out in CI notes on every open PR (#15158, #15162, #15173, #15185 at minimum, plus any PR a reporter opens in this window).

Fix

One line, plus a comment pointing future readers at the history so no one strips the kwarg again.

Before: ```python mock_fetch.assert_called_once_with("sk-test", "https://vllm.example.com/v1\", timeout=8.0) ```

After: ```python

fetch_api_models MUST be called even though model was saved.

api_mode was added to the production signature by 647900e8

("fix(cli): support model validation for anthropic_messages and

cloudflare-protected endpoints") — the test fixture has no

api_mode entry so api_mode or None resolves to None.

mock_fetch.assert_called_once_with( "sk-test", "https://vllm.example.com/v1\", timeout=8.0, api_mode=None, ) ```

The production call at `hermes_cli/main.py:2920-2923` is:

```python models = fetch_api_models( api_key, base_url, timeout=8.0, api_mode=api_mode or None, ) ```

where `api_mode` comes from `provider_info.get("api_mode", "")`. The test fixture has no `api_mode` entry so `api_mode or None` resolves to `None` — the expected assertion kwarg.

Related Issue

Fixes #15243

Type of Change

• 🔧 Test fix (no production behavior change)

Test plan

• All 6 tests in `TestCustomProviderModelSwitch` pass locally
• This failure has appeared on every open PR's `test` CI lane since 647900e8 landed — the fix clears it from the baseline failure set
• No production code touched

Changed files

• tests/hermes_cli/test_custom_provider_model_switch.py (modified, +8/-2)

---

PR #15254: test(cli): align custom provider probe assertion with api_mode kwarg

• Repository: NousResearch/hermes-agent
• Author: WadydX
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/15254

Description (problem / solution / changelog)

Summary

• update one stale test assertion to match current fetch_api_models call signature
• keep scope to test-only change in tests/hermes_cli/test_custom_provider_model_switch.py

Root cause

_model_flow_named_custom() now calls: fetch_api_models(api_key, base_url, timeout=8.0, api_mode=api_mode or None)

The test test_saved_model_still_probes_endpoint still expected a call without api_mode, which causes a false failure.

Validation

• uv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.py::TestCustomProviderModelSwitch::test_saved_model_still_probes_endpoint -vv
• uv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.py
• uv run pytest -q -n 0 tests/hermes_cli/test_custom_provider_model_switch.py::TestCustomProviderModelSwitch::test_saved_model_still_probes_endpoint tests/hermes_cli/test_plugin_scanner_recursion.py::TestKindField::test_unknown_kind_falls_back_to_standalone tests/hermes_cli/test_provider_config_validation.py::TestNormalizeCustomProviderEntry::test_unknown_keys_logged tests/hermes_cli/test_provider_config_validation.py::TestNormalizeCustomProviderEntry::test_camel_case_warning_logged -vv

Fixes #15243

Changed files

• tests/hermes_cli/test_custom_provider_model_switch.py (modified, +3/-1)

---

PR #15190: test(gateway): make systemd refresh tests hermetic with user D-Bus preflight

• Repository: NousResearch/hermes-agent
• Author: WadydX
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/15190

Description (problem / solution / changelog)

Summary

Fixes a test regression introduced by user D-Bus preflight checks in systemd user-scope commands.

This keeps runtime behavior unchanged and makes the affected unit tests hermetic again by stubbing _preflight_user_systemd where tests are specifically validating command sequencing / refresh behavior.

Changes

• Add monkeypatch.setattr(gateway_cli, "_preflight_user_systemd", lambda: None) in:
  • TestSystemdServiceRefresh::test_systemd_start_refreshes_outdated_unit
  • TestSystemdServiceRefresh::test_systemd_restart_refreshes_outdated_unit
  • TestGatewaySystemServiceRouting::test_systemd_restart_self_requests_graceful_restart_and_waits
  • TestGatewaySystemServiceRouting::test_systemd_restart_recovers_failed_planned_restart

Why

systemd_start() and systemd_restart() now call _preflight_user_systemd() before the mocked subprocess.run path. In non-systemd environments, those tests fail early with UserSystemdUnavailableError and never reach their intended assertions.

Validation

• pytest -q -n 0 tests/hermes_cli/test_gateway_service.py::TestSystemdServiceRefresh::test_systemd_start_refreshes_outdated_unit tests/hermes_cli/test_gateway_service.py::TestSystemdServiceRefresh::test_systemd_restart_refreshes_outdated_unit tests/hermes_cli/test_gateway_service.py::TestGatewaySystemServiceRouting::test_systemd_restart_self_requests_graceful_restart_and_waits tests/hermes_cli/test_gateway_service.py::TestGatewaySystemServiceRouting::test_systemd_restart_recovers_failed_planned_restart
• pytest -q -n 0 tests/hermes_cli/test_gateway_service.py

Closes #15187

Changed files

• tests/hermes_cli/test_gateway_service.py (modified, +4/-0)