PR #25715: fix(theme): add missing 'response' property to text schema in CustomTheme

• Repository: google-gemini/gemini-cli
• Author: nileshpatil6
• State: open | merged: False
• Link: https://github.com/google-gemini/gemini-cli/pull/25715

Description (problem / solution / changelog)

Problem

Setting text.response in a custom theme triggers a validation error at startup:

Invalid configuration... Unrecognized key(s) in object: 'response'

This is because the text object in the CustomTheme schema definition has additionalProperties: false but is missing the response property.

Reported in issue #25689.

Root cause

In settingsSchema.ts, the text properties block only lists primary, secondary, link, and accent. However, the runtime theme logic explicitly uses text.response:

response: customTheme.text?.response ?? customTheme.text?.primary ?? colors.Foreground

Since the schema has additionalProperties: false, any key not listed there is rejected — even though it's a documented, supported field.

Fix

Add response: { type: 'string' } to the text properties in the CustomTheme schema, consistent with the other color properties.

Fixes #25689

Changed files

• packages/cli/src/config/settingsSchema.ts (modified, +1/-0)

PR #25729: fix(cli): add missing custom theme properties to settings schema

• Repository: google-gemini/gemini-cli
• Author: NTaylorMullen
• State: open | merged: False
• Link: https://github.com/google-gemini/gemini-cli/pull/25729

Description (problem / solution / changelog)

Summary

This PR fixes a validation error when using certain properties in a custom theme configuration. Specifically, it adds support for text.response, ui.active, and ui.focus in the settings schema.

Details

• Added missing properties (text.response, ui.active, ui.focus) to the CustomTheme definition in packages/cli/src/config/settingsSchema.ts.
• Synchronized the CustomTheme interface in packages/core/src/config/config.ts by adding border.focused (which was already in the schema but missing from the interface).
• Added a comprehensive validation test case in packages/cli/src/config/settings-validation.test.ts to verify that these properties are now correctly accepted.

Related Issues

Fixes https://github.com/google-gemini/gemini-cli/issues/25689

How to Validate

1. Run the new validation tests: npm test -w @google/gemini-cli -- src/config/settings-validation.test.ts
2. Manually verify by creating a custom theme in your settings:

   ui:
     customThemes:
       test-theme:
         type: custom
         name: "Test Theme"
         text:
           response: "#00ff00"

   The CLI should no longer warn about unrecognized keys.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on MacOS

Changed files

• packages/cli/src/config/settings-validation.test.ts (modified, +30/-0)
• packages/cli/src/config/settingsSchema.ts (modified, +3/-0)
• packages/core/src/config/config.ts (modified, +1/-0)