openclaw - ✅(Solved) Fix Bug: 模型的 Think/Reasoning 内容被错误泄露给用户 [1 pull requests, 2 comments, 2 participants]

gzsiang · 2026-03-18T04:03:38Z

[openclaw] PR 61481: fix agents : harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final answer fallback leak - Repository:… # PR #61481: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak - Repository: openclaw/openclaw - Author: 100yenadmin - State: closed | merged: False - Link: https://github.com/openclaw/openclaw/pull/61481 ## Description (problem / solution / changelog) ## Summary - fix phase-aware visible text extraction so an explicit `final_answer` block never falls back to commentary or legacy unphased text when it sanitizes to empty - suppress all commentary-phase partial streaming output regardless of whether extracted visible text is non-empty - keep session-history HTTP/SSE sanitization aligned with the hardened chat history path - add regression tests covering both leak paths and the session-history follow-through ## Context This hardens the merged #59643 behavior against two P1 leaks: - fixes #61474 - fixes #61475 ## Related issues / bug family - related to #25592 - related to #59536 - related to #59918 - related to #44213 - related to #49438 - related to #53960 ## Parent / sibling PRs - parent: #59643 — core phase-separation fix (merged) - sibling: #61463 — phase-aware extraction in sessions-helpers, TUI, and history paths ## Remaining follow-ups from the same adversarial review - #61476 — replay splitting corrupts phase on mixed messages - #61477 — late-map buffering gates on key existence, not phase validity - #61478 — function-call replay silently loses malformed arguments ## Related open PRs - #59920 — prefer terminal reply fields in CLI JSONL parser - #61151 — drop partialJson streaming artifacts from session history - #61337 — disable OpenAI tool-use pairing repair ## Testing - npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/agents/pi-embedded-utils.test.ts src/agents/pi-embedded-subscribe.handlers.messages.test.ts - npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/gateway/sessions-history-http.test.ts ## Changed files - `.agents/skills/openclaw-parallels-smoke/SKILL.md` (modified, +13/-0) - `.agents/skills/openclaw-qa-testing/SKILL.md` (added, +86/-0) - `.agents/skills/openclaw-qa-testing/agents/openai.yaml` (added, +4/-0) - `.github/labeler.yml` (modified, +4/-0) - `.github/workflows/ci.yml` (modified, +7/-1) - `.github/workflows/control-ui-locale-refresh.yml` (modified, +2/-2) - `.github/workflows/openclaw-npm-release.yml` (modified, +1/-1) - `CHANGELOG.md` (modified, +40/-12) - `appcast.xml` (modified, +248/-116) - `apps/android/app/build.gradle.kts` (modified, +2/-2) - `apps/ios/Config/Version.xcconfig` (modified, +3/-3) - `apps/macos/Sources/OpenClaw/Resources/Info.plist` (modified, +2/-2) - `apps/macos/Sources/OpenClawProtocol/GatewayModels.swift` (modified, +14/-0) - `apps/shared/OpenClawKit/Sources/OpenClawKit/Resources/tool-display.json` (modified, +23/-0) - `apps/shared/OpenClawKit/Sources/OpenClawProtocol/GatewayModels.swift` (modified, +14/-0) - `docs/.generated/config-baseline.sha256` (modified, +4/-4) - `docs/.generated/plugin-sdk-api-baseline.sha256` (modified, +2/-2) - `docs/automation/tasks.md` (modified, +5/-0) - `docs/channels/discord.md` (modified, +1/-1) - `docs/channels/matrix.md` (modified, +29/-5) - `docs/cli/memory.md` (modified, +43/-15) - `docs/cli/update.md` (modified, +3/-1) - `docs/concepts/dreaming.md` (modified, +121/-194) - `docs/concepts/memory-qmd.md` (modified, +17/-1) - `docs/concepts/memory-search.md` (modified, +9/-8) - `docs/concepts/memory.md` (modified, +12/-8) - `docs/concepts/model-providers.md` (modified, +2/-0) - `docs/concepts/models.md` (modified, +2/-0) - `docs/docs.json` (modified, +8/-1) - `docs/gateway/configuration-reference.md` (modified, +31/-12) - `docs/help/faq.md` (modified, +36/-0) - `docs/help/testing.md` (modified, +22/-0) - `docs/install/updating.md` (modified, +1/-0) - `docs/plugins/architecture.md` (modified, +1/-0) - `docs/plugins/building-plugins.md` (modified, +1/-0) - `docs/plugins/manifest.md` (modified, +76/-30) - `docs/plugins/sdk-migration.md` (modified, +11/-1) - `docs/plugins/sdk-overview.md` (modified, +22/-9) - `docs/providers/bedrock-mantle.md` (modified, +20/-7) - `docs/providers/bedrock.md` (modified, +29/-0) - `docs/providers/comfy.md` (added, +201/-0) - `docs/providers/fal.md` (modified, +2/-1) - `docs/providers/google.md` (modified, +30/-0) - `docs/providers/index.md` (modified, +4/-0) - `docs/providers/minimax.md` (modified, +29/-0) - `docs/providers/models.md` (modified, +4/-0) - `docs/providers/openai.md` (modified, +10/-2) - `docs/providers/runway.md` (added, +63/-0) - `docs/providers/vydra.md` (added, +123/-0) - `docs/reference/memory-config.md` (modified, +117/-98) - `docs/tools/image-generation.md` (modified, +21/-17) - `docs/tools/index.md` (modified, +14/-7) - `docs/tools/lobster.md` (modified

openclaw2026-03-18 04:03:38

ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

GitHub issue URL

Helpful · Quick feedback

GitHub stats

openclaw/openclaw#49438•Fetched 2026-04-08 00:55:19

View on GitHub

Comments

Participants

Timeline

Reactions

Author

gzsiang

Participants

gzsiang

Hollychou924

Timeline (top)

commented ×2cross-referenced ×2

Fix Action

Fixed

Fixed by PR: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak (https://github.com/openclaw/openclaw/pull/61481)

PR fix notes

PR #61481: fix(agents): harden OpenAI phase-aware visible text — suppress commentary partials, prevent empty final_answer fallback leak

Repository: openclaw/openclaw
Author: 100yenadmin
State: closed | merged: False
Link: https://github.com/openclaw/openclaw/pull/61481

Description (problem / solution / changelog)

Summary

fix phase-aware visible text extraction so an explicit final_answer block never falls back to commentary or legacy unphased text when it sanitizes to empty
suppress all commentary-phase partial streaming output regardless of whether extracted visible text is non-empty
keep session-history HTTP/SSE sanitization aligned with the hardened chat history path
add regression tests covering both leak paths and the session-history follow-through

Context

This hardens the merged #59643 behavior against two P1 leaks:

fixes #61474
fixes #61475

Related issues / bug family

related to #25592
related to #59536
related to #59918
related to #44213
related to #49438
related to #53960

Parent / sibling PRs

parent: #59643 — core phase-separation fix (merged)
sibling: #61463 — phase-aware extraction in sessions-helpers, TUI, and history paths

Remaining follow-ups from the same adversarial review

#61476 — replay splitting corrupts phase on mixed messages
#61477 — late-map buffering gates on key existence, not phase validity
#61478 — function-call replay silently loses malformed arguments

Related open PRs

#59920 — prefer terminal reply fields in CLI JSONL parser
#61151 — drop partialJson streaming artifacts from session history
#61337 — disable OpenAI tool-use pairing repair

Testing

npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/agents/pi-embedded-utils.test.ts src/agents/pi-embedded-subscribe.handlers.messages.test.ts
npm exec -- node --no-maglev ./node_modules/vitest/vitest.mjs run --config vitest.config.ts src/gateway/sessions-history-http.test.ts

Changed files

.agents/skills/openclaw-parallels-smoke/SKILL.md (modified, +13/-0)
.agents/skills/openclaw-qa-testing/SKILL.md (added, +86/-0)
.agents/skills/openclaw-qa-testing/agents/openai.yaml (added, +4/-0)
.github/labeler.yml (modified, +4/-0)
.github/workflows/ci.yml (modified, +7/-1)
.github/workflows/control-ui-locale-refresh.yml (modified, +2/-2)
.github/workflows/openclaw-npm-release.yml (modified, +1/-1)
CHANGELOG.md (modified, +40/-12)
appcast.xml (modified, +248/-116)
apps/android/app/build.gradle.kts (modified, +2/-2)
apps/ios/Config/Version.xcconfig (modified, +3/-3)
apps/macos/Sources/OpenClaw/Resources/Info.plist (modified, +2/-2)
apps/macos/Sources/OpenClawProtocol/GatewayModels.swift (modified, +14/-0)
apps/shared/OpenClawKit/Sources/OpenClawKit/Resources/tool-display.json (modified, +23/-0)
apps/shared/OpenClawKit/Sources/OpenClawProtocol/GatewayModels.swift (modified, +14/-0)
docs/.generated/config-baseline.sha256 (modified, +4/-4)
docs/.generated/plugin-sdk-api-baseline.sha256 (modified, +2/-2)
docs/automation/tasks.md (modified, +5/-0)
docs/channels/discord.md (modified, +1/-1)
docs/channels/matrix.md (modified, +29/-5)
docs/cli/memory.md (modified, +43/-15)
docs/cli/update.md (modified, +3/-1)
docs/concepts/dreaming.md (modified, +121/-194)
docs/concepts/memory-qmd.md (modified, +17/-1)
docs/concepts/memory-search.md (modified, +9/-8)
docs/concepts/memory.md (modified, +12/-8)
docs/concepts/model-providers.md (modified, +2/-0)
docs/concepts/models.md (modified, +2/-0)
docs/docs.json (modified, +8/-1)
docs/gateway/configuration-reference.md (modified, +31/-12)
docs/help/faq.md (modified, +36/-0)
docs/help/testing.md (modified, +22/-0)
docs/install/updating.md (modified, +1/-0)
docs/plugins/architecture.md (modified, +1/-0)
docs/plugins/building-plugins.md (modified, +1/-0)
docs/plugins/manifest.md (modified, +76/-30)
docs/plugins/sdk-migration.md (modified, +11/-1)
docs/plugins/sdk-overview.md (modified, +22/-9)
docs/providers/bedrock-mantle.md (modified, +20/-7)
docs/providers/bedrock.md (modified, +29/-0)
docs/providers/comfy.md (added, +201/-0)
docs/providers/fal.md (modified, +2/-1)
docs/providers/google.md (modified, +30/-0)
docs/providers/index.md (modified, +4/-0)
docs/providers/minimax.md (modified, +29/-0)
docs/providers/models.md (modified, +4/-0)
docs/providers/openai.md (modified, +10/-2)
docs/providers/runway.md (added, +63/-0)
docs/providers/vydra.md (added, +123/-0)
docs/reference/memory-config.md (modified, +117/-98)
docs/tools/image-generation.md (modified, +21/-17)
docs/tools/index.md (modified, +14/-7)
docs/tools/lobster.md (modified, +11/-9)
docs/tools/music-generation.md (added, +208/-0)
docs/tools/plugin.md (modified, +1/-0)
docs/tools/slash-commands.md (modified, +1/-1)
docs/tools/video-generation.md (modified, +147/-84)
docs/web/control-ui.md (modified, +4/-1)
docs/web/dashboard.md (modified, +2/-0)
dream-diary-preview-v2.html (added, +399/-0)
dream-diary-preview-v3.html (added, +323/-0)
extensions/amazon-bedrock-mantle/api.ts (modified, +2/-0)
extensions/amazon-bedrock-mantle/bedrock-token-generator.d.ts (added, +6/-0)
extensions/amazon-bedrock-mantle/discovery.test.ts (modified, +101/-3)
extensions/amazon-bedrock-mantle/discovery.ts (modified, +64/-13)
extensions/amazon-bedrock-mantle/package.json (modified, +3/-0)
extensions/bluebubbles/src/accounts.ts (modified, +5/-1)
extensions/bluebubbles/src/monitor.ts (modified, +1/-1)
extensions/browser/src/browser/chrome.default-browser.test.ts (modified, +2/-6)
extensions/browser/src/browser/client-fetch.loopback-auth.test.ts (modified, +2/-6)
extensions/browser/src/browser/control-service.plugin-disabled.test.ts (modified, +2/-6)
extensions/browser/src/browser/profiles-service.test.ts (modified, +5/-8)
extensions/browser/src/browser/pw-tools-core.clamps-timeoutms-scrollintoview.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.batch.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.evaluate.abort.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.interactions.set-input-files.test.ts (modified, +2/-4)
extensions/browser/src/browser/pw-tools-core.last-file-chooser-arm-wins.test.ts (modified, +2/-6)
extensions/browser/src/browser/pw-tools-core.screenshots-element-selector.test.ts (modified, +2/-6)
extensions/browser/src/browser/routes/agent.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/routes/basic.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/server-context.existing-session.test.ts (modified, +3/-8)
extensions/browser/src/browser/server-context.hot-reload-profiles.test.ts (modified, +6/-12)
extensions/browser/src/browser/server-context.remote-profile-tab-ops.fallback.test.ts (modified, +2/-6)
extensions/browser/src/browser/server-context.remote-profile-tab-ops.playwright.test.ts (modified, +2/-6)
extensions/browser/src/browser/server-lifecycle.test.ts (modified, +3/-8)
extensions/browser/src/browser/server.control-server.test-harness.ts (modified, +2/-1)
extensions/browser/src/browser/server.evaluate-disabled-does-not-block-storage.test.ts (modified, +3/-8)
extensions/browser/src/cli/browser-cli.test-support.ts (modified, +1/-1)
extensions/browser/src/cli/command-format.ts (modified, +1/-1)
extensions/browser/src/config/config.ts (modified, +1/-1)
extensions/browser/src/core-api.ts (modified, +25/-20)
extensions/browser/src/doctor-browser.ts (modified, +1/-1)
extensions/browser/src/gateway/auth.ts (modified, +1/-1)
extensions/browser/src/gateway/startup-auth.ts (modified, +1/-1)
extensions/browser/src/infra/errors.ts (modified, +1/-1)
extensions/browser/src/infra/fs-safe.ts (modified, +1/-1)
extensions/browser/src/infra/net/proxy-env.ts (modified, +1/-1)
extensions/browser/src/infra/net/ssrf.ts (modified, +1/-1)
extensions/browser/src/infra/path-guards.ts (modified, +1/-1)
extensions/browser/src/infra/ports.ts (modified, +1/-1)

RAW_BUFFERClick to expand / collapse

Bug: 模型的 Think/Reasoning 内容被错误泄露给用户

问题描述

当使用配置了 reasoning: true 的模型（如 qwen/qwen3.5-35b-a3b）时，模型的 thinking/reasoning 内容被错误地输出到了用户可见的回复中。

复现步骤

配置模型并设置 "reasoning": true
向 Agent 提问
Agent 的回复中会包含类似以下内容：

"主人说理解了解决方案，我应该确认 SearXNG 功能正常，用轻松的语气回应并询问是否需要其他帮助。"

这类内容明显是模型的 internal thinking 过程，不应该暴露给用户。

环境信息

OpenClaw 版本：2026.3.13
模型：5600x-local/qwen/qwen3.5-35b-a3b
配置文件模型设置："reasoning": true

预期行为

模型的 reasoning/thinking 内容应该被自动过滤，只向用户展示最终的回复内容。

实际行为

Think 内容被直接输出到用户可见的回复中。

临时绕过方案：将模型的 reasoning 设为 false。需要说明的是，这只是不展示思考过程，模型仍然会深度思考，回复质量不受影响。

extent analysis

Fix Plan

To fix the issue of the model's thinking/reasoning content being incorrectly exposed to users, we need to modify the code to filter out the internal thinking process from the final response.

Step-by-Step Solution

Locate the Response Generation Code: Find the part of the code responsible for generating the final response to the user.
Add a Filtering Mechanism: Implement a filter to remove the thinking/reasoning content from the response.
Conditionally Apply the Filter: Apply the filter only when the "reasoning": true configuration is set.

Example Code Snippet

def generate_response(model_output, config):
    if config["reasoning"]:
        # Filter out thinking/reasoning content
        filtered_response = [line for line in model_output if not line.startswith("主人说")]
        return "\n".join(filtered_response)
    else:
        return model_output

# Example usage
model_output = [
    "主人说理解了解决方案，我应该确认 SearXNG 功能正常，用轻松的语气回应并询问是否需要其他帮助。",
    "您好，SearXNG 功能正常。"
]
config = {"reasoning": True}

final_response = generate_response(model_output, config)
print(final_response)  # Output: "您好，SearXNG 功能正常。"

Verification

To verify that the fix worked, test the model with the "reasoning": true configuration and check that the thinking/reasoning content is no longer visible in the final response.

Extra Tips

Make sure to update the documentation to reflect the changes made to the response generation code.
Consider adding a configuration option to allow users to opt-in to seeing the thinking/reasoning content, if desired.

Vote matrix · Quick signals

Works

Did the solution work? Tap to confirm.

Easy Fix

Was it a quick fix?

Time Saver

Did it save you time?

Blocking

Was it severely blocking?

Common Issue

Are others likely hitting this too?

Flaky / Intermittent

Is it intermittent?

Verified / Reproducible

Can you reproduce it reliably?

#api #ssr #installation #tensor shape #autograd error #integration issue #index setup #retrieval issue #search optimization #API routing

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.