PR #59112: fix(exec): strip invalid approval policy enums during config normalization

• Repository: openclaw/openclaw
• Author: openperf
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/59112

Description (problem / solution / changelog)

Summary

This PR fixes the malformed exec-approvals.json policy-value path from #59006.

When ~/.openclaw/exec-approvals.json contains invalid enum values such as defaults.security: "none", normalizeExecApprovals() was preserving those raw strings in memory. Downstream exec policy resolution assumes normalized values, so those invalid strings could leak into comparisons like minSecurity() / maxAsk() and produce inconsistent behavior instead of cleanly falling back to the documented defaults.

The fix is intentionally narrow:

• validate security, ask, and askFallback while normalizing the file
• strip invalid or malformed values to undefined
• let the existing resolution layer fall back to built-in defaults

What Changed

• src/infra/exec-approvals.ts
  • added a small policy sanitizer for security, ask, and askFallback
  • non-string values are treated as invalid and stripped instead of reaching the enum normalizers directly
  • kept the rest of normalizeExecApprovals() focused on structural cleanup
• src/infra/exec-approvals-config.test.ts
  • added focused coverage for invalid defaults values, invalid agent values, non-string malformed values, and downstream fallback behavior

Scope Boundary

This PR does not change:

• sandbox or host target selection
• allowlist evaluation logic
• built-in exec approval defaults
• approval routing or channel behavior

It only ensures that malformed policy values from exec-approvals.json do not corrupt the in-memory exec approvals config.

Reproduction

1. Set an invalid approvals policy value in ~/.openclaw/exec-approvals.json, for example:

   {
     "version": 1,
     "defaults": {
       "security": "none"
     },
     "agents": {}
   }

2. Run exec through a path that loads the approvals file.
3. Before this fix, the invalid string was preserved and could poison downstream policy comparisons.
4. After this fix, the invalid value is stripped during normalization and downstream resolution falls back to the intended defaults.

Verification

• pnpm test -- src/infra/exec-approvals-config.test.ts
• pnpm build
• pnpm check

Change Type (select all)

• Bug fix

Scope (select all touched areas)

• Gateway
• Core
• Security

Linked Issue/PR

Addresses the malformed exec-approvals.json policy-value path in #59006.

Changed files

• src/infra/exec-approvals-config.test.ts (modified, +104/-0)
• src/infra/exec-approvals.ts (modified, +32/-6)