openclaw - 💡(How to fix) Fix [Bug]: update --timeout accepts partially numeric strings despite positive-integer contract [1 pull requests]

Official PRs (…)
ON THIS PAGE

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

A local code audit found that update CLI timeout parsing accepts partially numeric strings even though the option contract is a positive integer in seconds.

Error Message

Add update CLI timeout validation cases for 1.5 and 10abc that expect the existing positive-integer error and exit path.

Root Cause

A local code audit found that update CLI timeout parsing accepts partially numeric strings even though the option contract is a positive integer in seconds.

Fix Action

Fixed

RAW_BUFFERClick to expand / collapse

Summary

A local code audit found that update CLI timeout parsing accepts partially numeric strings even though the option contract is a positive integer in seconds.

Affected area

  • src/cli/update-cli/shared.ts
  • parseTimeoutMsOrExit

Repro

Pass values such as --timeout 1.5 or --timeout 10abc to an update subcommand. The parser accepts the numeric prefix instead of rejecting the full value.

Expected

The parser should reject any value that is not entirely a positive integer string.

Suggested fix

Trim the input and require a full-string decimal integer match, then verify the parsed number is a safe positive integer before converting seconds to milliseconds.

Suggested regression test

Add update CLI timeout validation cases for 1.5 and 10abc that expect the existing positive-integer error and exit path.

Source: local code audit.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

openclaw - 💡(How to fix) Fix [Bug]: update --timeout accepts partially numeric strings despite positive-integer contract [1 pull requests]