PR #24945: fix(cli): exclude update_topic from confirmation queue count

• Repository: google-gemini/gemini-cli
• Author: Abhijit-2592
• State: open | merged: False
• Link: https://github.com/google-gemini/gemini-cli/pull/24945

Description (problem / solution / changelog)

Summary

This PR centralizes tool visibility logic to fix UI inconsistencies, such as the update_topic tool inflating the confirmation queue count ("X of Y").

Details

The logic that dictates whether a tool call should be visible in the chat history, the active tool group, or the confirmation queue was previously fragmented across the codebase (ToolGroupMessage.tsx, confirmingTool.ts, useGeminiStream.ts).

Specifically, the update_topic tool is an auto-executing background operation that does not require user interaction. Because it was included in the calculation of the tool confirmation queue size in confirmingTool.ts, the UI showed misleading counts (e.g., "1 of 2") when only one actionable tool was actually pending.

This PR introduces a unified tool-visibility utility in the core package that exposes three semantic methods:

• isRenderedInHistory
• requiresUserConfirmation
• isVisibleInToolGroup

This cleanly resolves UI inconsistencies by providing a single source of truth for tool visibility state, removing the need for the UI to manually check against specific tool names like update_topic.

examples

Before

Queue count shows "1 of 2" when an update_topic tool is executing alongside another actionable tool.

After

Queue count accurately shows "1 of 1", excluding background narrative updates.

Related Issues

Fixes #24944

How to Validate

1. Run npm test -w @google/gemini-cli-core -- src/utils/tool-visibility.test.ts to ensure the core rules are functioning correctly.
2. Run npm test -w @google/gemini-cli to ensure existing UI tests pass.
3. Manually verify by triggering a turn with update_topic and another tool; the count should only reflect actionable tools.

Pre-Merge Checklist

[ ] Updated relevant documentation and README (if needed) [x] Added/updated tests (if needed) [ ] Noted breaking changes (if any) [x] Validated on required platforms/methods: [x] MacOS [x] npm run

Changed files

• packages/cli/src/ui/components/messages/ToolGroupMessage.tsx (modified, +14/-34)
• packages/cli/src/ui/hooks/useGeminiStream.ts (modified, +6/-4)
• packages/cli/src/ui/utils/confirmingTool.ts (modified, +18/-3)
• packages/cli/src/ui/utils/historyUtils.ts (modified, +13/-1)
• packages/core/src/index.ts (modified, +1/-0)
• packages/core/src/utils/tool-utils.test.ts (modified, +2/-105)
• packages/core/src/utils/tool-utils.ts (modified, +1/-66)
• packages/core/src/utils/tool-visibility.test.ts (added, +159/-0)
• packages/core/src/utils/tool-visibility.ts (added, +119/-0)