hermes - โœ…(Solved) Fix [Bug]: /v1/props should be GET /props [1 pull requests]

Official PRs (โ€ฆ)
ON THIS PAGE

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful ยท Quick feedback

Loadingโ€ฆ

Error Message

Additional Logs / Traceback (optional)

Root Cause

Root Cause Analysis (optional)

PR fix notes

PR #13317: fix(model_metadata): use /props endpoint at server root for llama.cpp

Description (problem / solution / changelog)

What broke

When using llama.cpp as a provider, Hermes requested /v1/props endpoint which returned 404 because llama.cpp exposes /props at server root (not under /v1 prefix per httplib routes). Users saw 404 errors in llama-server logs.

Root cause

The comment incorrectly stated "llama.cpp exposes /v1/props (older builds used /props)". Actually, per llama.cpp's httplib routes (server.cpp line 174: ctx_http.get("/props", ...)), /props is at server root. The endpoint order was reversed: /v1/props was tried before /props.

Why this fix is minimal

  • Only changes endpoint order: try /props first (server root), then /v1/props as fallback
  • Strips /v1 prefix from base_url to get server root for /props request
  • Preserves fallback for alternative builds/configs that might use /v1 path
  • No changes to response body parsing or other server type detection

What I tested

  • Added regression tests for /props endpoint detection
  • Tests verify correct URL construction with /v1 prefix stripping
  • Tests cover fallback to /v1/props when /props returns 404

What I intentionally did not change

  • Response body parsing (default_generation_settings check unchanged)
  • Other server type detection (LM Studio, Ollama, vLLM unchanged)
  • Error handling and fallback logic structure

Fixes #13091

Changed files

  • agent/model_metadata.py (modified, +9/-6)
  • tests/agent/test_model_metadata_local_ctx.py (modified, +84/-0)

Code Example

n/a

---
RAW_BUFFERClick to expand / collapse

Bug Description

/v1/props should be GET /props when targeting llama.cpp. The fix in Hermes would be to call /props relative to the server root, not the OpenAI base path.

Using llama-server with flag --props

Steps to Reproduce

using llama-server with flag --props

Expected Behavior

srv log_server_r: done request: GET /props 192.168.3.51 200

Actual Behavior

from the log files when using llama.cpp

srv log_server_r: done request: GET /v1/props 192.168.3.51 404

Affected Component

Other

Messaging Platform (if gateway-related)

No response

Debug Report

n/a

Operating System

windows 11

Python Version

No response

Hermes Version

0.10

Additional Logs / Traceback (optional)

Root Cause Analysis (optional)

No response

Proposed Fix (optional)

The fix in Hermes would be to call /props relative to the server root, not the OpenAI base path.

Are you willing to submit a PR for this?

  • I'd like to fix this myself and submit a PR

extent analysis

TL;DR

The issue can likely be fixed by changing the request path in Hermes to call /props relative to the server root instead of the OpenAI base path.

Guidance

  • Verify that the llama-server flag --props is correctly set and that the server is configured to handle requests to /props.
  • Check the Hermes configuration to ensure that the request path is being constructed correctly, and update it to use the server root path instead of the OpenAI base path.
  • Test the fix by running the llama-server with the --props flag and verifying that the request is made to the correct path (/props instead of /v1/props).
  • Review the server logs to confirm that the request is being handled correctly and that the expected response is being returned.

Example

No code snippet is provided as the issue does not contain sufficient information about the code.

Notes

The fix assumes that the Hermes configuration can be updated to use the server root path. If this is not possible, alternative solutions may be needed.

Recommendation

Apply workaround: update the Hermes configuration to call /props relative to the server root, as this is the proposed fix mentioned in the issue.

Vote matrix ยท Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loadingโ€ฆ

Still need to ship something?

ร—6

Another batch ranked right after the header list โ€” different links, same matching logic.

Back to top recommendations

TRENDING

hermes - โœ…(Solved) Fix [Bug]: /v1/props should be GET /props [1 pull requests]