PR #16885: fix(opencode): preserve /v1 in base_url when switching from anthropic_messages to chat_completions models

• Repository: NousResearch/hermes-agent
• Author: quannon
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16885

Description (problem / solution / changelog)

Summary

When using the opencode-go provider with a config default model that uses anthropic_messages mode (e.g. minimax-m2.7) and switching to a chat_completions model (e.g. deepseek-v4-flash) via the /model slash command, the base_url loses /v1, resulting in an HTTP 404 error.

Fixes: https://github.com/NousResearch/hermes-agent/issues/16878

Root Cause

In runtime_provider.py, the non-pool "API-key providers" block (~lines 1213-1237), when the credential pool is exhausted:

1. configured_mode = _parse_api_mode(model_cfg.get("api_mode")) reads "anthropic_messages" from the stale config
2. This stale mode is applied before the opencode-go/zen api_mode detection can run
3. The opencode block was an elif, so it never ran when configured_mode was truthy

Fix Applied

Promoted opencode-go/zen detection to an explicit if block that runs before the configured_mode override, so it always correctly detects api_mode based on the target model.

Same change applied to _resolve_runtime_from_pool_entry for consistency.

Verification

# default=minimax-m2.7 → switch to deepseek-v4-flash
resolve_runtime_provider(requested="opencode-go", target_model="deepseek-v4-flash")
# → api_mode="chat_completions", base_url="https://opencode.ai/zen/go/v1" ✓

# reverse: default=deepseek-v4-flash → switch to minimax-m2.7
resolve_runtime_provider(requested="opencode-go", target_model="minimax-m2.7")
# → api_mode="anthropic_messages", base_url="https://opencode.ai/zen/go" ✓

Tests

12/12 passing: python -m pytest tests/hermes_cli/test_model_switch_opencode_anthropic.py -v

Changed files

• hermes_cli/runtime_provider.py (modified, +18/-10)

PR #16888: fix(opencode): re-derive api_mode per target model on /model switch

• Repository: NousResearch/hermes-agent
• Author: Sanjays2402
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/16888

Description (problem / solution / changelog)

What

opencode-zen and opencode-go each serve both anthropic_messages models (e.g. minimax-m2.7) and chat_completions models (e.g. deepseek-v4-flash) behind a single base_url (https://opencode.ai/zen/go/v1). When the user starts a session with a minimax-m2.7 default and runs /model deepseek-v4-flash, the api_mode resolver in hermes_cli/runtime_provider.py honours the persisted model_cfg.api_mode (= anthropic_messages, set by the previous default) before checking the opencode model registry, so the deepseek turn inherits anthropic_messages, strips /v1 from base_url (the Anthropic SDK adds its own /v1/messages), and 404s.

Reported and root-caused in #16878.

Fix

Promote the opencode detection branch above the configured_mode check in both api_mode resolution paths:

• _resolve_runtime_from_pool_entry — pool-backed providers (~line 262)
• _resolve_api_key_runtime — API-key fallback (~line 1213)

Both branches now call opencode_model_api_mode(provider, effective_model) unconditionally for opencode-zen / opencode-go before considering any persisted api_mode, so the mode always reflects the model the user just switched to. Other providers retain the existing precedence (persisted api_mode > URL detection).

Tests

Existing suite passes:

$ pytest tests/hermes_cli/test_model_switch_opencode_anthropic.py
............                                                             [100%]
12 passed, 13 warnings in 4.31s

This covers both the minimax-m2.7 → deepseek-v4-flash direction (the failing case in the issue) and the reverse deepseek-v4-flash → minimax-m2.7, which stays correct because the same code path also re-derives the mode from the target model.

Diff

hermes_cli/runtime_provider.py | 28 +++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)

Fixes #16878

Changed files

• hermes_cli/runtime_provider.py (modified, +19/-9)
• run_agent.py (modified, +17/-10)

PR #16890: fix(opencode): re-derive api_mode per target model on /model switch

• Repository: NousResearch/hermes-agent
• Author: teknium1
• State: closed | merged: True
• Link: https://github.com/NousResearch/hermes-agent/pull/16890

Description (problem / solution / changelog)

Salvages PR #16888 (opencode fix only — the second stacked reasoning_content commit from that PR is dropped; it is a separate concern tracked under #16844 and will be evaluated on its own).

Summary

/model deepseek-v4-flash from a minimax-m2.7 default on opencode-go / opencode-zen 404'd. The api_mode resolver honoured the persisted api_mode: anthropic_messages (set when minimax was default) before the opencode model registry, so the deepseek turn inherited anthropic_messages, stripped /v1 from base_url, and went to https://opencode.ai/zen/go/messages instead of .../v1/chat/completions.

Fixes #16878.

Changes

• hermes_cli/runtime_provider.py — promote the opencode-zen/go branch above the configured_mode check in both api_mode resolution paths (_resolve_runtime_from_pool_entry and the API-key fallback in resolve_runtime_provider). opencode always re-derives mode from the effective target_model; other providers keep existing precedence (persisted api_mode > URL detection).
• tests/hermes_cli/test_runtime_provider_resolution.py — rename + invert test_opencode_go_configured_api_mode_still_overrides_default (added in #4508) to lock in the new precedence. A persisted chat_completions on a minimax model no longer wins — the model dictates the mode. Escape-hatch for opencode is intentionally removed; the model name is the unambiguous signal.

Validation

Suites: tests/hermes_cli/test_runtime_provider_resolution.py, test_model_switch_opencode_anthropic.py, test_model_switch_custom_providers.py — 109/109 pass. E2E verified against origin/main with a real config.yaml and isolated HERMES_HOME.

Credit: @Sanjays2402 for the original fix (#16888).

Changed files

• hermes_cli/runtime_provider.py (modified, +19/-9)
• tests/hermes_cli/test_runtime_provider_resolution.py (modified, +13/-2)