vllm - 💡(How to fix) Fix [CI Failure]: mi325_1: PyTorch Compilation Passes Unit Tests [1 comments, 1 participants]

Fix Plan

The fix involves updating the test group to handle silu, rmsnorm, and rope failures.

• Identify and update the failing test cases:
  • Check the test files in tests/compile/passes for silu, rmsnorm, and rope related tests.
  • Update the test cases to correctly handle these operations.
• Example code snippet to update a test case:

import pytest

@pytest.mark.parametrize("operation", ["silu", "rmsnorm", "rope"])
def test_compile_passes(operation):
    # Update the test logic to handle the operation
    if operation == "silu":
        # Add silu specific test logic
        pass
    elif operation == "rmsnorm":
        # Add rmsnorm specific test logic
        pass
    elif operation == "rope":
        # Add rope specific test logic
        pass
    # Rest of the test logic

• Run the updated test group to verify the fixes:
  • Use the command pytest -s -v tests/compile/passes --ignore tests/compile/passes/distributed

Verification

To verify the fix, run the test group and check for any remaining failures.

Extra Tips

• Make sure to update the test cases to handle any edge cases for silu, rmsnorm, and rope operations.
• If the failures persist, try to isolate the issue by running individual test cases.