vllm - 💡(How to fix) Fix [CI/Perf] Invalid JSON in serving benchmark config [1 pull requests]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

.buildkite/performance-benchmarks/tests/serving-tests.json is currently invalid JSON on main.

The file contains a stray duplicate object after serving_llama8B_tp1_sharegpt, so JSON parsers fail before the serving benchmark suite can read the default config.

Error Message

parse error: Objects must consist of key:value pairs at line 35, column 5

Root Cause

run-performance-benchmarks.sh defaults to serving-tests$ARCH.json, and the non-arch-specific default points at tests/serving-tests.json. That means the default serving benchmark config is broken on the current main branch.

Fix Action

Fixed

Code Example

jq . .buildkite/performance-benchmarks/tests/serving-tests.json

---

parse error: Objects must consist of key:value pairs at line 35, column 5
RAW_BUFFERClick to expand / collapse

Summary

.buildkite/performance-benchmarks/tests/serving-tests.json is currently invalid JSON on main.

The file contains a stray duplicate object after serving_llama8B_tp1_sharegpt, so JSON parsers fail before the serving benchmark suite can read the default config.

Repro

jq . .buildkite/performance-benchmarks/tests/serving-tests.json

Current result:

parse error: Objects must consist of key:value pairs at line 35, column 5

I also verified the same failure with Python json.load.

Why this matters

run-performance-benchmarks.sh defaults to serving-tests$ARCH.json, and the non-arch-specific default points at tests/serving-tests.json. That means the default serving benchmark config is broken on the current main branch.

Likely regression source

git blame points the malformed block to 5d041cc1fe5181daabf39943efc7b678380d57bd from PR #43262.

Expected fix

Remove the stray duplicate object and add a small validation guard so future benchmark config edits fail fast if one of these JSON files becomes unparsable again.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING