Issue Station
Sign In
Tools hereToolbox

claude-code - 💡(How to fix) Fix Claude Code generated semantically incorrect class-validator decorator composition

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Claude Code generated code with a subtle but critical semantic error in decorator composition that passed type-checking but caused runtime failures against real data. Two separate AI code review tools also failed to catch the bug during PR review.

Error Message

Claude Code generated code with a subtle but critical semantic error in decorator composition that passed type-checking but caused runtime failures against real data. Two separate AI code review tools also failed to catch the bug during PR review. 3. AI review tools also missed it: Two separate AI code review bots reviewed the 1,200+ line PR and only flagged a cosmetic inconsistency. Neither caught the two breaking validation bugs. This suggests the class of error (correct syntax, incorrect semantics in decorator/annotation composition) is a systemic gap across current AI tooling.

Root Cause

  • The bug was deployed to a dev environment and caused HTTP 500 errors on a critical API flow
  • It was caught before reaching production, but only because a developer manually tested the flow
  • If it had reached production, it would have been a P1 incident affecting all users of the affected feature

Code Example

@IsArray()
@IsOptional()
@ValidateNested({ each: true })
@Type(() => String)
titles?: string[];

---

@IsArray()
@IsOptional()
@IsString({ each: true })
titles?: string[];
RAW_BUFFERClick to expand / collapse

Summary

Claude Code generated code with a subtle but critical semantic error in decorator composition that passed type-checking but caused runtime failures against real data. Two separate AI code review tools also failed to catch the bug during PR review.

What happened

Claude Code was used to sync entity classes between NestJS services into a shared SDK package. During the sync, it generated the following decorator composition on a string[] field:

@IsArray()
@IsOptional()
@ValidateNested({ each: true })
@Type(() => String)
titles?: string[];

@ValidateNested({ each: true }) combined with @Type(() => String) tells class-validator to treat each string element as a nested object requiring validation. Since strings are primitives (not objects), every string in the array fails with: "each value in nested property titles must be either object or array".

The correct pattern for a string array is:

@IsArray()
@IsOptional()
@IsString({ each: true })
titles?: string[];

In the same PR, Claude Code also generated entity fields with @IsNotEmpty() (via a custom decorator) on credential fields that legitimately contain empty strings in the database. The fix required adding allowEmpty: true.

Impact

  • The bug was deployed to a dev environment and caused HTTP 500 errors on a critical API flow
  • It was caught before reaching production, but only because a developer manually tested the flow
  • If it had reached production, it would have been a P1 incident affecting all users of the affected feature

Why this matters for Claude Code

  1. Decorator composition is a blind spot: Each decorator is individually valid, but the combination is semantically incorrect. Claude Code needs better understanding of how class-validator decorators interact at runtime — specifically that @ValidateNested expects class instances, not primitives.

  2. Data-dependent correctness: The allowEmpty issue only manifests when the database contains empty strings. Claude Code should be more conservative when generating validation decorators on fields that may contain edge-case values (empty strings, nulls, etc.), especially when syncing from a service where the data shape is determined by real-world usage, not just the type definition.

  3. AI review tools also missed it: Two separate AI code review bots reviewed the 1,200+ line PR and only flagged a cosmetic inconsistency. Neither caught the two breaking validation bugs. This suggests the class of error (correct syntax, incorrect semantics in decorator/annotation composition) is a systemic gap across current AI tooling.

Environment

  • Claude Code was used to generate the PR (badge: "Generated with Claude Code")
  • The PR was a large entity sync (~1,200 lines, ~30 files) — entity classes bulk-copied from a source service
  • NestJS + class-validator + class-transformer stack

extent analysis

TL;DR

Update the decorator composition for string arrays to use @IsString({ each: true }) instead of @ValidateNested({ each: true }) and @Type(() => String).

Guidance

  • Review the generated code for decorator composition, especially when using class-validator and class-transformer, to ensure semantic correctness.
  • Verify that the validation decorators match the expected data shape, considering edge cases like empty strings or null values.
  • Consider adding allowEmpty: true to @IsNotEmpty() decorators for fields that may contain empty strings.
  • Manually test critical API flows after deploying code generated by tools like Claude Code to catch potential runtime errors.

Example

// Incorrect decorator composition
@IsArray()
@IsOptional()
@ValidateNested({ each: true })
@Type(() => String)
titles?: string[];

// Corrected decorator composition
@IsArray()
@IsOptional()
@IsString({ each: true })
titles?: string[];

Notes

The fix may not be applicable to all cases, as the correct decorator composition depends on the specific use case and data shape. Additionally, the issue highlights the importance of manual testing and review, even with AI-powered code generation and review tools.

Recommendation

Apply the workaround by updating the decorator composition for string arrays and adding allowEmpty: true to @IsNotEmpty() decorators as needed, as this addresses the specific issues mentioned in the problem.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#api#memory management#API rate limit#retriever error#indexing error

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

claude-code - 💡(How to fix) Fix Claude Code generated semantically incorrect class-validator decorator composition