hermes - 💡(How to fix) Fix CLI session-name coalescing swallows real top-level subcommands like 'logs', 'debug', and 'claw' [1 participants]

TL;DR

Update the _SUBCOMMANDS allowlist in hermes_cli/main.py to include all registered top-level subcommands, such as debug, claw, and logs, to prevent them from being absorbed into session names.

Guidance

• Review the current implementation of _coalesce_session_name_args() and _SUBCOMMANDS in hermes_cli/main.py to understand how session names are coalesced and how the allowlist is used.
• Derive the stop-list from the actual parser or registered top-level subcommands instead of maintaining a hand-maintained set to ensure accuracy and prevent missing commands.
• Add regression tests for at least logs, debug, and claw to verify that they are not absorbed into session names when used with unquoted session names.
• Consider updating the documentation to reflect the expected behavior and any changes made to the _SUBCOMMANDS allowlist.

Example

# Example of how to derive the stop-list from the actual parser
import argparse

parser = argparse.ArgumentParser()
subcommands = [subcommand for subcommand in parser._subparsers._actions]
_SUBCOMMANDS = [subcommand.dest for subcommand in subcommands]

Notes

This solution assumes that the argparse library is being used to parse commands and that the _SUBCOMMANDS allowlist is the only factor in determining whether a command is absorbed into a session name. Additional testing and verification may be necessary to ensure that this solution works as expected in all scenarios.

Recommendation

Apply workaround by updating the _SUBCOMMANDS allowlist to include all registered top-level subcommands, as this will prevent valid commands from being silently folded into session titles.