litellm - 💡(How to fix) Fix Code quality: 454 silent exception swallows across core — router, utils, providers, proxy [1 comments, 1 participants]

We ran HefestoAI (deterministic static analysis, no AI/LLM) against litellm (3,935 files) and found 454 instances of silent exception swallowing across core modules. This is the highest density we have seen in any major open source project. For an LLM proxy that routes requests across 100+ providers, silent error masking means provider failures, rate limit errors, authentication issues, and malformed responses can be silently swallowed — returning empty/incorrect results instead of surfacing the error to the caller.

• 454 SILENT_EXCEPTION_SWALLOW — except Exception: pass/return None/return []/return {} Silent swallows in utility functions used across the entire codebase. Error conditions in helpers propagate silently to every caller. Silent swallows in the logging system itself — errors in error reporting. One or two except Exception: pass in edge cases is normal. 454 across a single codebase indicates a systematic pattern — likely a team convention of "catch everything, don't crash." While the intent (reliability) is good, the effect (invisible failures) is the opposite. Each silent swallow is a point where the system chooses to lie to the caller rather than admit it failed.

TL;DR

Review and refactor the 454 instances of silent exception swallowing in the litellm codebase to properly handle and propagate errors.

Guidance

• Identify and prioritize the most critical instances of silent exception swallowing, focusing on the core routing engine and utility functions.
• Implement try-except blocks that catch specific exceptions, log the errors, and re-raise or return meaningful error messages to the caller.
• Review the logging system to ensure it properly reports errors and exceptions, rather than silently swallowing them.
• Consider introducing a coding standard or linter rule to prevent future instances of silent exception swallowing.

Example

# Before
try:
    # code that may raise an exception
except Exception:
    pass

# After
try:
    # code that may raise an exception
except Exception as e:
    logger.error(f"An error occurred: {e}")
    raise

Notes

The sheer number of silent exception swallows suggests a systematic pattern, and addressing this issue may require a thorough code review and refactoring effort. It's essential to balance the need for reliability with the need for transparency and error reporting.

Recommendation

Apply a workaround by implementing a coding standard or linter rule to prevent future instances of silent exception swallowing, and prioritize refactoring the existing codebase to properly handle and propagate errors. This approach will help ensure that errors are properly reported and handled, rather than being silently swallowed.