PR #19929: TUI: use cumulative turn duration for worked-for separator

• Repository: openai/codex
• Author: etraut-openai
• State: open | merged: False
• Link: https://github.com/openai/codex/pull/19929

Description (problem / solution / changelog)

Why

Fixes #19814.

The TUI's current Worked for ... timing behavior is a leftover from #9599. At that point, models could emit multiple assistant messages in one turn for preambles/commentary, but the TUI did not yet have a reliable signal that an assistant message was the final answer when it started streaming. To avoid showing an ever-growing elapsed time on each preamble separator, #9599 made the separator timer incremental by tracking elapsed time since the previous separator.

That workaround is no longer the right model for the final completed-turn display. Since then, #16638 added protocol-native turn timing, including duration_ms on turn completion. With that cumulative duration available at the point where the TUI renders the completed-turn separator, the UI can show the actual turn duration directly instead of carrying per-separator timing state.

What Changed

• Thread duration_ms into ChatWidget::on_task_complete from both legacy TurnCompleteEvent handling and app-server TurnCompleted notifications.
• Use duration_ms for the final Worked for ... separator, falling back to the status indicator timer only when the protocol duration is unavailable.
• Keep mid-turn separators before later assistant text as plain visual dividers instead of clocked Worked for ... separators.
• Remove the old incremental separator timer state and helper (last_separator_elapsed_secs / worked_elapsed_from).
• Add a snapshot regression test for a turn that runs a command and then completes with a final answer, verifying the final separator uses the cumulative turn duration.

Verification

• cargo test -p codex-tui final_worked_for_uses_cumulative_turn_duration_snapshot
• just fix -p codex-tui

Manual repro prompt:

Manual timing repro. First send a short preamble/commentary sentence before using tools. Then run exactly this shell command: sleep 75; echo MANUAL_TIMING_DONE. After the command finishes, give a final answer that says "done". Do not skip the preamble.

After this change, the mid-turn break before the final answer should be a plain divider, and the final completed-turn separator should show Worked for ... using the cumulative turn duration.

Before: <img width="414" height="102" alt="Screenshot 2026-04-27 at 10 09 01 PM" src="https://github.com/user-attachments/assets/b9e2ce01-2460-40e4-a5c4-c9ba8add2557" />

After: <img width="485" height="149" alt="Screenshot 2026-04-27 at 10 09 07 PM" src="https://github.com/user-attachments/assets/d24089ae-d4e2-41b6-b966-07c98706ead4" />

Changed files

• codex-rs/tui/src/chatwidget.rs (modified, +29/-37)
• codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__final_worked_for_uses_cumulative_turn_duration.snap (added, +12/-0)
• codex-rs/tui/src/chatwidget/tests/exec_flow.rs (modified, +56/-2)
• codex-rs/tui/src/chatwidget/tests/helpers.rs (modified, +0/-1)
• codex-rs/tui/src/chatwidget/tests/plan_mode.rs (modified, +20/-6)
• codex-rs/tui/src/chatwidget/tests/status_and_layout.rs (modified, +3/-11)
• codex-rs/tui/src/history_cell.rs (modified, +1/-1)