PR #80366: fix(configure): allow pruning stale provider models

• Repository: openclaw/openclaw
• Author: jbetala7
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/80366

Description (problem / solution / changelog)

Summary

• include same-provider configured allowlist entries that are missing from the current model catalog in provider-scoped configure picker options
• include those stale configured entries in the scoped write set, so unselecting them prunes only that provider's dead entries while preserving unrelated providers
• add a regression test covering the OpenRouter stale-model shape from #80347

Fixes #80347.

Real behavior proof (required for external PRs)

Behavior or issue addressed: Provider-scoped openclaw configure allowlist cleanup omitted same-provider configured model keys that disappeared from the current provider catalog, so stale delisted entries stayed in agents.defaults.models forever.

Real environment tested: Local OpenClaw checkout on branch fix/80347-configure-stale-models, running the real promptModelAllowlist and applyModelAllowlist code paths with a local config matching the OpenRouter stale-model shape from #80347. The API key in the proof config/output is a redacted test value and no provider request was sent.

Exact steps or command run after this patch: node --import tsx /private/tmp/openclaw-80347-proof.mjs

Evidence after fix: Terminal output from the command above:

picker options: openrouter/meta-llama/llama-3.3-70b:free [Llama 3.3 70B · ctx 125k · alias: llama] | openrouter/elephant-alpha [configured (not in catalog)]
initial values: openrouter/meta-llama/llama-3.3-70b:free | openrouter/elephant-alpha
operator selection: openrouter/meta-llama/llama-3.3-70b:free
selection result: {"models":["openrouter/meta-llama/llama-3.3-70b:free"],"scopeKeys":["openrouter/meta-llama/llama-3.3-70b:free","openrouter/elephant-alpha"]}
models after configure: anthropic/claude-sonnet-4-6 | openrouter/meta-llama/llama-3.3-70b:free
stale model present after configure: false

Observed result after fix: The stale same-provider key openrouter/elephant-alpha is shown in the picker as configured (not in catalog), is included in scopeKeys, and is removed after the operator leaves it unselected. The unrelated Anthropic allowlist entry remains present.

What was not tested: I did not run an interactive terminal openclaw configure session against a live OpenRouter account; the proof exercises the underlying configure picker/apply path directly with a local config and redacted credentials.

Verification

• pnpm test src/commands/model-picker.test.ts src/commands/configure.gateway-auth.prompt-auth-config.test.ts
• pnpm exec oxfmt --check --threads=1 src/flows/model-picker.ts src/commands/model-picker.test.ts CHANGELOG.md
• git diff --check
• pnpm check:changed

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/commands/model-picker.test.ts (modified, +59/-0)
• src/flows/model-picker.ts (modified, +14/-1)