openclaw - 💡(How to fix) Fix [control-ui] Image attachments cleared before WebSocket send — images lost on connection failure [1 participants]

TL;DR

Clearing the chatAttachments state should be done after the WebSocket message is successfully sent via pp(), with a try-catch block to restore attachments on send failure.

Guidance

• The current implementation clears chatAttachments before sending the message, which can lead to data loss if the WebSocket connection fails.
• To fix this, the chatAttachments state should be cleared only after pp() successfully returns, ensuring that attachments are not lost in case of a send failure.
• A try-catch block can be used to catch any errors that occur during the send operation and restore the chatAttachments state if an error occurs.
• The suggested fix provided in the issue description appears to be a viable solution, using try and catch to handle the send operation and restore attachments on failure.

Example

const prev = e.chatAttachments;
e.chatAttachments = []; // Clear UI immediately for responsiveness
try {
  await pp(e, {...});
} catch(err) {
  e.chatAttachments = prev; // Restore on failure
}

Notes

This fix assumes that the pp() function returns a promise that resolves when the send operation is successful, and rejects when an error occurs. If this is not the case, additional modifications may be necessary.

Recommendation

Apply the suggested workaround using a try-catch block to restore attachments on send failure, as it directly addresses the identified issue and prevents data loss.