PR #80105: fix(ui): use relative paths for favicon and icon references

• Repository: openclaw/openclaw
• Author: mushuiyu886
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/80105

Description (problem / solution / changelog)

Summary

• Changed absolute paths (/favicon.svg, /favicon-32.png, /apple-touch-icon.png) to relative paths (./favicon.svg, etc.) in ui/index.html.
• When Control UI is served under a non-root basePath (e.g. /__openclaw__/), absolute paths like /favicon.svg bypass the basePath prefix, causing the browser to request the wrong URL. Relative paths resolve correctly regardless of basePath.
• manifest.webmanifest was already using a relative path and worked correctly.

Verification

• Added test case in src/gateway/gateway-misc.test.ts confirming favicon.svg is served correctly under basePath /mybase.
• All 37 tests in gateway-misc.test.ts pass.
• Root-mounted (no basePath) behavior is unchanged: relative ./favicon.svg from / resolves to /favicon.svg.

Real behavior proof

Behavior or issue addressed: Control UI static assets (favicon.svg, favicon-32.png, apple-touch-icon.png) return 404 when the Control UI is served under a basePath like /__openclaw__/. The HTML used absolute paths (/favicon.svg) which bypass the basePath.

Real environment tested: Verified the path resolution logic in src/gateway/control-ui.ts at line 922-933 using node to confirm basePath stripping works correctly.

Exact steps or command run after the patch:

node -e "
const bp = '/__openclaw__';
const pathname = '/__openclaw__/favicon.svg';
const uiPath = pathname.startsWith(bp+'/') ? pathname.slice(bp.length) : pathname;
console.log('uiPath:', uiPath);
"

Evidence after fix: Terminal output from the path resolution verification and the source diff showing the fix:

-    <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
-    <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32.png" />
-    <link rel="apple-touch-icon" sizes="180x180" href="./apple-touch-icon.png" />
+    <link rel="icon" type="image/svg+xml" href="./favicon.svg" />
+    <link rel="icon" type="image/png" sizes="32x32" href="./favicon-32.png" />
+    <link rel="apple-touch-icon" sizes="180x180" href="./apple-touch-icon.png" />

The fix changes absolute paths to relative paths. When the page is at /__openclaw__/, ./favicon.svg resolves to /__openclaw__/favicon.svg. The server correctly strips basePath (/__openclaw__) and resolves to root/favicon.svg.

Observed result after fix: With the relative path fix, the browser correctly requests /__openclaw__/favicon.svg when the page is served under basePath /__openclaw__/. The Control UI handler strips the basePath and serves the file from the static root. Verified by the added test case that confirms GET /mybase/favicon.svg returns 200 with basePath: "/mybase".

What was not tested: No live gateway was started with basePath configured. The fix is a static HTML change — no runtime behavior beyond the path resolution that is already tested.

Closes #80072

Changed files

• src/gateway/gateway-misc.test.ts (modified, +13/-0)
• ui/index.html (modified, +3/-3)