PR #67807: fix(cron): clean up deleteAfterRun direct deliveries

• Repository: openclaw/openclaw
• Author: MonkeyLeeT
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/67807

Description (problem / solution / changelog)

Summary

• Problem: direct cron deliveries only cleaned up deleteAfterRun sessions on the text-finalization path; structured payloads and threaded direct deliveries could leave isolated cron sessions behind.
• Why it matters: deleteAfterRun jobs could accumulate transcript state and hit the context-overflow behavior reported in #67718.
• What changed: direct delivery now routes through a shared cleanup wrapper, and session deletion is deduplicated per dispatch so silent direct deliveries only issue one sessions.delete call.
• What did NOT change (scope boundary): this does not change cron retention policy, the session reaper, or job-store deletion rules.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #67718
• Related #
• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: cleanup for deleteAfterRun direct cron sessions was attached to the text finalization path, but the structured direct-delivery and threaded direct-delivery branches called deliverViaDirect without that cleanup.
• Missing detection / guardrail: there was no regression test asserting cleanup for the raw useDirectDelivery branches, and no guard against duplicate deletion after refactoring cleanup into a shared wrapper.
• Contributing context (if known): silent direct deliveries can return through the same direct path after payload normalization, which made duplicate cleanup easy to introduce.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: src/cron/isolated-agent/delivery-dispatch.double-announce.test.ts
• Scenario the test should lock in: deleteAfterRun cleans up after threaded direct deliveries, structured direct deliveries, and structured silent replies without double-deleting the session.
• Why this is the smallest reliable guardrail: the bug lives entirely inside dispatchCronDelivery branch selection and cleanup behavior, so the isolated dispatch test file exercises the exact control flow without extra cron runtime noise.
• Existing test that already covers this (if any): existing text and silent cleanup assertions in the same file covered only the text-finalization path.
• If no new test is added, why not: N/A

User-visible / Behavior Changes

Cron jobs using deleteAfterRun: true now reliably delete isolated direct-delivery sessions after structured payload sends and threaded direct sends. Silent direct deliveries still clean up the session, but only issue one delete call.

Diagram (if applicable)

Before:
[direct delivery with structured payload/thread target] -> [send succeeds] -> [session kept]

After:
[direct delivery with structured payload/thread target] -> [send succeeds] -> [shared cleanup wrapper] -> [session deleted once]

Security Impact (required)

• New permissions/capabilities? (No)
• Secrets/tokens handling changed? (No)
• New/changed network calls? (No)
• Command/tool execution surface changed? (No)
• Data access scope changed? (No)
• If any Yes, explain risk + mitigation:

Repro + Verification

Environment

• OS: macOS
• Runtime/container: local Node test lane
• Model/provider: N/A
• Integration/channel (if any): cron direct-delivery dispatch
• Relevant config (redacted): deleteAfterRun: true, isolated cron session

Steps

1. Run a cron agent turn that resolves to direct delivery through the structured-payload path or threaded direct-delivery path.
2. Set deleteAfterRun: true on the job.
3. Observe session cleanup behavior after delivery completes.

Expected

• The isolated cron session is deleted after direct delivery finishes.
• Silent direct deliveries delete the session exactly once.

Actual

• Before this change, the structured/threaded direct-delivery branches could skip cleanup entirely.

Evidence

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Human Verification (required)

• Verified scenarios: targeted dispatch tests for threaded direct delivery cleanup, structured direct delivery cleanup, and structured silent direct delivery single-delete behavior.
• Edge cases checked: silent direct replies after payload normalization.
• What you did not verify: full pnpm test / repo-wide gate in this shell, because the local environment lacks a pnpm binary on PATH; verification used the underlying Vitest cron config directly.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes)
• Config/env changes? (No)
• Migration needed? (No)
• If yes, exact upgrade steps:

Risks and Mitigations

• Risk: cleanup now runs through a shared wrapper for direct deliveries, which could accidentally double-delete the session on silent direct replies.
  • Mitigation: the dispatch now tracks whether deletion already succeeded, and the regression test asserts a single sessions.delete call for the structured silent path.

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/cron/isolated-agent/delivery-dispatch.double-announce.test.ts (modified, +57/-1)
• src/cron/isolated-agent/delivery-dispatch.ts (modified, +16/-7)