Issue Station
Sign In
Tools hereToolbox

pytorch - ✅(Solved) Fix DISABLED test_activation_benchmark (__main__.ComboKernelBenchmarkTestsPerSubkernelBlocks) [2 pull requests, 1 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#180011•Fetched 2026-04-11 06:10:14
View on GitHub
Comments
1
Participants
2
Timeline
88
Reactions
0
Author
praguptapragupta
Participants
praguptapraguptapytorch-bot[bot]pytorch-bot[bot]
Timeline (top)
mentioned ×38subscribed ×38labeled ×9unlabeled ×2

Root Cause

This test was disabled because it is failing on main branch (recent examples).

PR fix notes

PR #180277: [ROCm][inductor][UT] Preserve combo kernel HIP compile options

Description (problem / solution / changelog)

Fixes #180011 Fixes #180012 Fixes #180013 Fixes #180014 Fixes #180015 Fixes #180016 Fixes #180021 Fixes #179952 Fixes #180022 Fixes #180025 Fixes #180027 Fixes #180028 Fixes #180029 Fixes #180549

This appears to have regressed in #177715, where combo-kernel autotuning started materializing alternate per-subkernel configs. This change keeps Triton HIP compile options such as waves_per_eu, matrix_instr_nonkdim, and kpack kernel-wide when combo kernels rewrite per-subkernel configs, avoiding invalid names like waves_per_eu_0. It also routes both baseline combo configs and sequential combo autotune trials through the same kwarg rewrite helper and adds a regression test covering combo-kernel kwarg rewriting for AMD special config args.

Made with Cursor

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos

Changed files

  • test/inductor/test_combo_kernels.py (modified, +26/-0)
  • torch/_inductor/runtime/triton_heuristics.py (modified, +60/-26)

PR #180319: [ROCm] Handle profiler trace format differences in combo kernel tests

Description (problem / solution / changelog)

Fixes #180017. Fixes #180018. Fixes #180019.

Three combo kernel tests access event["args"]["grid"] from profiler chrome traces. The grid key structure differs between CUPTI and ROCTracer trace formats, so this throws KeyError on ROCm.

Use .get() and only assert on grid values when present. All other validation (numerical correctness, kernel counts, codegen) still runs. No change to CUDA path where grid is always present there so assertions execute as before.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Changed files

  • test/inductor/test_combo_kernels.py (modified, +25/-14)
RAW_BUFFERClick to expand / collapse

Platforms: rocm

This test was disabled because it is failing on main branch (recent examples).

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @jerrymannil @xinyazhang @mruberry @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @aakhundov @coconutruben

extent analysis

TL;DR

The test test_activation_benchmark in test_combo_kernels.py needs to be investigated and fixed to resolve the failure on the main branch.

Guidance

  • Review the recent failure examples on torch-ci.com to understand the nature of the test failure.
  • Investigate the test_activation_benchmark method in test_combo_kernels.py to identify potential issues with the test or the code it is testing.
  • Check if there are any platform-specific issues related to rocm that could be causing the test to fail.
  • Consider re-enabling the test and running it locally to gather more information about the failure.

Notes

The root cause of the issue is not clear from the provided information, and further investigation is needed to determine the solution.

Recommendation

Apply workaround: Investigate and fix the test failure, as the issue seems to be specific to the test_activation_benchmark test and may require changes to the test or the code it is testing.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#task chaining#parallel task#integration issue#index setup#retrieval issue

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_activation_benchmark (__main__.ComboKernelBenchmarkTestsPerSubkernelBlocks) [2 pull requests, 1 comments, 2 participants]