Issue Station
Sign In
Tools hereToolbox

pytorch - ✅(Solved) Fix DISABLED test_combo_autotune_grouping (__main__.ComboKernelTestsMaxAutotune) [1 pull requests, 4 comments, 4 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#180549•Fetched 2026-04-17 08:26:29
View on GitHub
Comments
4
Participants
4
Timeline
95
Reactions
0
Author
guangyeyguangyey
Participants
guangyeyguangyeyjeffdailyjeffdailykarthickaikarthickaipytorch-bot[bot]pytorch-bot[bot]
Assignees
karthickaikarthickai
Timeline (top)
mentioned ×39subscribed ×39labeled ×7commented ×4

Root Cause

This test was disabled because it is failing on main branch (recent examples).

Fix Action

Fixed

PR fix notes

PR #180277: [ROCm][inductor][UT] Preserve combo kernel HIP compile options

Description (problem / solution / changelog)

Fixes #180011 Fixes #180012 Fixes #180013 Fixes #180014 Fixes #180015 Fixes #180016 Fixes #180021 Fixes #179952 Fixes #180022 Fixes #180025 Fixes #180027 Fixes #180028 Fixes #180029 Fixes #180549

This appears to have regressed in #177715, where combo-kernel autotuning started materializing alternate per-subkernel configs. This change keeps Triton HIP compile options such as waves_per_eu, matrix_instr_nonkdim, and kpack kernel-wide when combo kernels rewrite per-subkernel configs, avoiding invalid names like waves_per_eu_0. It also routes both baseline combo configs and sequential combo autotune trials through the same kwarg rewrite helper and adds a regression test covering combo-kernel kwarg rewriting for AMD special config args.

Made with Cursor

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos

Changed files

  • test/inductor/test_combo_kernels.py (modified, +26/-0)
  • torch/_inductor/runtime/triton_heuristics.py (modified, +60/-26)
RAW_BUFFERClick to expand / collapse

Platforms: rocm, xpu

This test was disabled because it is failing on main branch (recent examples).

cc @mruberry @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @aakhundov @coconutruben @jataylo @gujinghui @fengyuan14

extent analysis

TL;DR

The test test_combo_autotune_grouping in test_combo_kernels.py needs to be fixed or re-enabled to resolve the failure on the main branch.

Guidance

  • Investigate the recent failures on torch-ci.com to understand the root cause of the test failure.
  • Review the test case test_combo_autotune_grouping in test_combo_kernels.py to identify potential issues.
  • Consider re-enabling the test and running it locally to reproduce and debug the failure.
  • Check if there are any platform-specific issues related to rocm or xpu that might be causing the test to fail.

Notes

The issue lacks specific technical details, so a more detailed analysis of the test failure is needed to provide a concrete solution.

Recommendation

Apply workaround: Re-enable the test and debug it locally to identify the root cause of the failure, as the issue seems to be related to a specific test case rather than a version issue.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#ssr#cache issue#memory leak#API versioning#request timeout

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_combo_autotune_grouping (__main__.ComboKernelTestsMaxAutotune) [1 pull requests, 4 comments, 4 participants]