Issue Station
Sign In
Tools hereToolbox

pytorch - ✅(Solved) Fix DISABLED test_combo_kernel_yz_overflow (__main__.ComboKernelTests) [2 pull requests, 1 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#180019•Fetched 2026-04-11 06:09:59
View on GitHub
Comments
1
Participants
2
Timeline
64
Reactions
0
Author
praguptapragupta
Participants
praguptapraguptapytorch-bot[bot]pytorch-bot[bot]
Timeline (top)
mentioned ×28subscribed ×28labeled ×7commented ×1

Root Cause

This test was disabled because it is failing on main branch (recent examples).

PR fix notes

PR #180319: [ROCm] Handle profiler trace format differences in combo kernel tests

Description (problem / solution / changelog)

Fixes #180017. Fixes #180018. Fixes #180019.

Three combo kernel tests access event["args"]["grid"] from profiler chrome traces. The grid key structure differs between CUPTI and ROCTracer trace formats, so this throws KeyError on ROCm.

Use .get() and only assert on grid values when present. All other validation (numerical correctness, kernel counts, codegen) still runs. No change to CUDA path where grid is always present there so assertions execute as before.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Changed files

  • test/inductor/test_combo_kernels.py (modified, +25/-14)

PR #180689: [ROCm] Handle profiler trace format differences in combo kernel tests

Description (problem / solution / changelog)

Fixes #180017. Fixes #180018. Fixes #180019.

Three combo kernel tests access event["args"]["grid"] from profiler chrome traces. The grid key structure differs between CUPTI and ROCTracer trace formats, so this throws KeyError on ROCm.

Use .get() and only assert on grid values when present. All other validation (numerical correctness, kernel counts, codegen) still runs. No change to CUDA path where grid is always present there so assertions execute as before.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Changed files

  • test/inductor/test_combo_kernels.py (modified, +25/-14)
RAW_BUFFERClick to expand / collapse

Platforms: rocm

This test was disabled because it is failing on main branch (recent examples).

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @jerrymannil @xinyazhang @mruberry @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @aakhundov @coconutruben

extent analysis

TL;DR

The test test_combo_kernel_per_config_subkernel_block_size in test_combo_kernels.py is failing on the main branch and needs to be investigated and fixed.

Guidance

  • Review the recent failure examples on torch-ci.com to understand the failure patterns and potential causes.
  • Investigate the test_combo_kernel_per_config_subkernel_block_size test in test_combo_kernels.py to identify the root cause of the failure.
  • Check the test configuration and subkernel block size settings to ensure they are correct and compatible with the ROCm platform.
  • Consider re-enabling the test and running it locally to reproduce and debug the issue.

Notes

The issue lacks specific technical details, so a thorough investigation is required to determine the root cause and develop a fix.

Recommendation

Apply workaround: Investigate and fix the failing test to ensure the codebase is stable and functional on the ROCm platform.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#dependency error#configuration error#environment variable#network issue#logging issue

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_combo_kernel_yz_overflow (__main__.ComboKernelTests) [2 pull requests, 1 comments, 2 participants]