pytorch - ✅(Solved) Fix DISABLED test_dynamic_lstm (__main__.TestExport) [1 pull requests, 2 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#176995Fetched 2026-04-08 00:23:15
View on GitHub
Comments
2
Participants
2
Timeline
42
Reactions
0
Timeline (top)
mentioned ×16subscribed ×16labeled ×4commented ×2

Error Message

Traceback (most recent call last): File "/var/lib/jenkins/workspace/test/export/test_export.py", line 1334, in test_dynamic_lstm self.assertEqual(eager_out_gru, ep_out_gru) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/_dynamo/test_case.py", line 113, in assertEqual return super().assertEqual(x, y, *args, **kwargs) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/testing/_internal/common_utils.py", line 4365, in assertEqual raise error_metas.pop()[0].to_error( # type: ignore[index] ...<4 lines>... ) AssertionError: Tensor-likes are not close!

Mismatched elements: 563 / 262144 (0.2%) Greatest absolute difference: 3.3736228942871094e-05 at index (0, 8, 370) (up to 1e-05 allowed) Greatest relative difference: 0.13132105767726898 at index (0, 11, 149) (up to 1.3e-06 allowed)

To execute this test, run the following from the base repo dir: PYTORCH_TEST_WITH_CROSSREF=1 python test/export/test_export.py TestExport.test_dynamic_lstm

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Root Cause

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Fix Action

Fixed

PR fix notes

PR #177304: [export] Fix dynamic_lstm test

Description (problem / solution / changelog)

Fixes https://github.com/pytorch/pytorch/issues/176995

When we export we disable mkldnn, which causes some numerical discrepancies when we compare it against the eager path which uses mkldnn. This PR just adds a decorator so that we compare the eager path w/o mkldnn

Changed files

Code Example

Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/export/test_export.py", line 1334, in test_dynamic_lstm
    self.assertEqual(eager_out_gru, ep_out_gru)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/_dynamo/test_case.py", line 113, in assertEqual
    return super().assertEqual(x, y, *args, **kwargs)
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/testing/_internal/common_utils.py", line 4365, in assertEqual
    raise error_metas.pop()[0].to_error(  # type: ignore[index]
    ...<4 lines>...
    )
AssertionError: Tensor-likes are not close!

Mismatched elements: 563 / 262144 (0.2%)
Greatest absolute difference: 3.3736228942871094e-05 at index (0, 8, 370) (up to 1e-05 allowed)
Greatest relative difference: 0.13132105767726898 at index (0, 11, 149) (up to 1.3e-06 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_CROSSREF=1 python test/export/test_export.py TestExport.test_dynamic_lstm

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
RAW_BUFFERClick to expand / collapse

Platforms: asan, linux

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 6 hours, it has been determined flaky in 3 workflow(s) with 3 failures and 3 successes.

Debugging instructions (after clicking on the recent samples link): DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs. To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_dynamic_lstm
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/export/test_export.py", line 1334, in test_dynamic_lstm
    self.assertEqual(eager_out_gru, ep_out_gru)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/_dynamo/test_case.py", line 113, in assertEqual
    return super().assertEqual(x, y, *args, **kwargs)
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/py_3.14/lib/python3.14/site-packages/torch/testing/_internal/common_utils.py", line 4365, in assertEqual
    raise error_metas.pop()[0].to_error(  # type: ignore[index]
    ...<4 lines>...
    )
AssertionError: Tensor-likes are not close!

Mismatched elements: 563 / 262144 (0.2%)
Greatest absolute difference: 3.3736228942871094e-05 at index (0, 8, 370) (up to 1e-05 allowed)
Greatest relative difference: 0.13132105767726898 at index (0, 11, 149) (up to 1.3e-06 allowed)

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_WITH_CROSSREF=1 python test/export/test_export.py TestExport.test_dynamic_lstm

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
</details>

Test file path: export/test_export.py

For all disabled tests (by GitHub issue), see https://hud.pytorch.org/disabled.

cc @chauhang @penguinwu @avikchaudhuri @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4

extent analysis

Fix Plan

Step 1: Identify the root cause of the flaky test

The flaky test is likely due to the assertion error in the test_dynamic_lstm function. The error message indicates that the tensor-likes are not close, with a mismatched element count and greatest absolute difference.

Step 2: Update the test to handle floating-point precision issues

To fix the flaky test, we need to update the test to handle floating-point precision issues. We can use the torch.testing.assert_close function instead of self.assertEqual to compare the tensor-likes.

import torch

# ...

def test_dynamic_lstm(self):
    # ...
    eager_out_gru = ...  # compute eager_out_gru
    ep_out_gru = ...  # compute ep_out_gru
    torch.testing.assert_close(eager_out_gru, ep_out_gru, atol=1e-5, rtol=1e-6)
    # ...

Step 3: Update the test to handle tensor-likes with different shapes

If the tensor-likes have different shapes, we need to update the test to handle this case. We can use the torch.testing.assert_close function with the rtol and atol arguments to specify the relative and absolute tolerance, respectively.

import torch

# ...

def test_dynamic_lstm(self):
    # ...
    eager_out_gru = ...  # compute eager_out_gru
    ep_out_gru = ...  # compute ep_out_gru
    torch.testing.assert_close(eager_out_gru, ep_out_gru, atol=1e-5, rtol=1e-6, equal_nan=True)
    # ...

Step 4: Run the test with the updated code

Run the test with the updated code to verify that the fix works.

PYTORCH_TEST_WITH_CROSSREF

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_dynamic_lstm (__main__.TestExport) [1 pull requests, 2 comments, 2 participants]