pytorch - ✅(Solved) Fix DISABLED test_fixed_striding (__main__.TestWithNCCL) [2 pull requests, 1 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#179949Fetched 2026-04-11 06:11:24
View on GitHub
Comments
1
Participants
2
Timeline
68
Reactions
0
Author
Timeline (top)
mentioned ×31subscribed ×31labeled ×5commented ×1

Root Cause

This test was disabled because it is failing on main branch (recent examples).

PR fix notes

PR #180518: [ROCm] Fix evaluate_platform_supports_fp8 false-positive

Description (problem / solution / changelog)

On ROCm, evaluate_platform_supports_fp8() did not return False when the device architecture did not match any supported FP8 GPU, causing the function to fall through and report support unconditionally.

Add an explicit False return when no supported ROCm architecture is matched, ensuring correct FP8 capability detection on unsupported devices.

Fixes #179960 Fixes #179949

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @pragupta @jerrymannil @xinyazhang

Changed files

  • torch/testing/_internal/common_cuda.py (modified, +1/-0)

PR #180715: [ROCm] Fix evaluate_platform_supports_fp8 false-positive

Description (problem / solution / changelog)

On ROCm, evaluate_platform_supports_fp8() did not return False when the device architecture did not match any supported FP8 GPU, causing the function to fall through and report support unconditionally.

Add an explicit False return when no supported ROCm architecture is matched, ensuring correct FP8 capability detection on unsupported devices.

Fixes #179960 Fixes #179949

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @pragupta @jerrymannil @xinyazhang

Changed files

  • torch/testing/_internal/common_cuda.py (modified, +1/-0)
RAW_BUFFERClick to expand / collapse

Platforms: rocm

This test was disabled because it is failing on main branch (recent examples).

cc @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @msaroufim @dcci @aditvenk @xmfan @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @jerrymannil @xinyazhang

extent analysis

TL;DR

The test test_fixed_striding in test_c10d_functional_native.py needs to be investigated and fixed to resolve the failure on the main branch.

Guidance

  • Investigate the recent failures on torch-ci.com to understand the error messages and stack traces.
  • Review the test case test_fixed_striding in test_c10d_functional_native.py to identify potential issues with the test itself or its dependencies.
  • Check the differences between the main branch and other branches where the test might be passing to identify potential regressions.
  • Consider re-enabling the test and running it locally or on a CI environment to reproduce and debug the issue.

Notes

The issue lacks specific technical details about the failure, so a more detailed analysis of the test and its environment is necessary to provide a precise fix.

Recommendation

Apply workaround: temporarily skip or disable the failing test until a proper fix can be implemented, to allow the main branch to move forward while the issue is being investigated.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_fixed_striding (__main__.TestWithNCCL) [2 pull requests, 1 comments, 2 participants]