pytorch - 💡(How to fix) Fix DISABLED test_hints_wrapper (__main__.HigherOrderOpTestsWithCompiledAutograd)

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Error Message

Traceback (most recent call last): File "/w/pytorch/pytorch/test/dynamo/test_higher_order_ops.py", line 3299, in test_hints_wrapper self.assertExpectedInline( File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/internal/common_utils.py", line 3490, in assertExpectedInline return super().assertExpectedInline(actual if isinstance(actual, str) else str(actual), expect, skip + 1) File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/init.py", line 413, in assertExpectedInline assert_expected_inline( File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/init.py", line 378, in assert_expected_inline assert_eq(expect, actual, msg=help_text) File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/init.py", line 450, in assertMultiLineEqualMaybeCppStack self.assertMultiLineEqual(expect, actual, *args, **kwargs) File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 1226, in assertMultiLineEqual self.fail(self.formatMessage(msg, standardMsg)) File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 675, in fail raise self.failureException(msg) AssertionError: 'clas[160 chars] l_x + l_y; l_x = None\n\n hints_wr[1113 chars],)\n' != 'clas[160 chars] l_x.add(l_y_); l_x_ = None\n hints_w[1114 chars],)\n' class GraphModule(torch.nn.Module): def forward(self, L_x_: "f32[2, 4]", L_y_: "f32[4]"): l_x_ = L_x_ l_y_ = L_y_

  •     x: "f32[2, 4]" = l_x_ + l_y_;  l_x_ = None

? ^^^

  •     x: "f32[2, 4]" = l_x_.add(l_y_);  l_x_ = None

? ^^^^^ +

      hints_wrapper_body_1 = self.hints_wrapper_body_1
      hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_1, (x, l_y_), {}, hints = {'outer_body': True});  hints_wrapper_body_1 = x = l_y_ = None
      getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None
      return (getitem,)

  class hints_wrapper_body_1(torch.nn.Module):
      def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
          hints_wrapper_body_0 = self.hints_wrapper_body_0
          hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_0, (x, l_y_), {}, hints = {'inner_body': True});  hints_wrapper_body_0 = x = l_y_ = None
          getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None

          x_1: "f32[2, 4]" = torch.abs(getitem);  getitem = None
          return (x_1,)

      class hints_wrapper_body_0(torch.nn.Module):
          def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
              x_1: "f32[2, 4]" = torch.relu(x);  x = None

              x_2: "f32[2, 4]" = x_1 + l_y_;  x_1 = l_y_ = None
              return (x_2,)

: To accept the new output, re-run test with envvar EXPECTTEST_ACCEPT=1 (we recommend staging/committing your changes before doing this)

To execute this test, run the following from the base repo dir: python test/dynamo/test_higher_order_ops.py HigherOrderOpTestsWithCompiledAutograd.test_hints_wrapper

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Root Cause

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Code Example

Traceback (most recent call last):
  File "/__w/pytorch/pytorch/test/dynamo/test_higher_order_ops.py", line 3299, in test_hints_wrapper
    self.assertExpectedInline(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3490, in assertExpectedInline
    return super().assertExpectedInline(actual if isinstance(actual, str) else str(actual), expect, skip + 1)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 413, in assertExpectedInline
    assert_expected_inline(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 378, in assert_expected_inline
    assert_eq(expect, actual, msg=help_text)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 450, in assertMultiLineEqualMaybeCppStack
    self.assertMultiLineEqual(expect, actual, *args, **kwargs)
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 1226, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 675, in fail
    raise self.failureException(msg)
AssertionError: 'clas[160 chars] l_x_ + l_y_;  l_x_ = None\n\n        hints_wr[1113 chars],)\n' != 'clas[160 chars] l_x_.add(l_y_);  l_x_ = None\n        hints_w[1114 chars],)\n'
  class GraphModule(torch.nn.Module):
      def forward(self, L_x_: "f32[2, 4]", L_y_: "f32[4]"):
          l_x_ = L_x_
          l_y_ = L_y_
  
-         x: "f32[2, 4]" = l_x_ + l_y_;  l_x_ = None
?                              ^^^
+         x: "f32[2, 4]" = l_x_.add(l_y_);  l_x_ = None
?                              ^^^^^    +
- 
          hints_wrapper_body_1 = self.hints_wrapper_body_1
          hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_1, (x, l_y_), {}, hints = {'outer_body': True});  hints_wrapper_body_1 = x = l_y_ = None
          getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None
          return (getitem,)
  
      class hints_wrapper_body_1(torch.nn.Module):
          def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
              hints_wrapper_body_0 = self.hints_wrapper_body_0
              hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_0, (x, l_y_), {}, hints = {'inner_body': True});  hints_wrapper_body_0 = x = l_y_ = None
              getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None
  
              x_1: "f32[2, 4]" = torch.abs(getitem);  getitem = None
              return (x_1,)
  
          class hints_wrapper_body_0(torch.nn.Module):
              def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
                  x_1: "f32[2, 4]" = torch.relu(x);  x = None
  
                  x_2: "f32[2, 4]" = x_1 + l_y_;  x_1 = l_y_ = None
                  return (x_2,)
 : To accept the new output, re-run test with envvar EXPECTTEST_ACCEPT=1 (we recommend staging/committing your changes before doing this)

To execute this test, run the following from the base repo dir:
    python test/dynamo/test_higher_order_ops.py HigherOrderOpTestsWithCompiledAutograd.test_hints_wrapper

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
RAW_BUFFERClick to expand / collapse

Platforms: linux, slow

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 6 hours, it has been determined flaky in 3 workflow(s) with 6 failures and 3 successes.

Debugging instructions (after clicking on the recent samples link): DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs. To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_hints_wrapper
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
Traceback (most recent call last):
  File "/__w/pytorch/pytorch/test/dynamo/test_higher_order_ops.py", line 3299, in test_hints_wrapper
    self.assertExpectedInline(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3490, in assertExpectedInline
    return super().assertExpectedInline(actual if isinstance(actual, str) else str(actual), expect, skip + 1)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 413, in assertExpectedInline
    assert_expected_inline(
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 378, in assert_expected_inline
    assert_eq(expect, actual, msg=help_text)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/expecttest/__init__.py", line 450, in assertMultiLineEqualMaybeCppStack
    self.assertMultiLineEqual(expect, actual, *args, **kwargs)
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 1226, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/case.py", line 675, in fail
    raise self.failureException(msg)
AssertionError: 'clas[160 chars] l_x_ + l_y_;  l_x_ = None\n\n        hints_wr[1113 chars],)\n' != 'clas[160 chars] l_x_.add(l_y_);  l_x_ = None\n        hints_w[1114 chars],)\n'
  class GraphModule(torch.nn.Module):
      def forward(self, L_x_: "f32[2, 4]", L_y_: "f32[4]"):
          l_x_ = L_x_
          l_y_ = L_y_
  
-         x: "f32[2, 4]" = l_x_ + l_y_;  l_x_ = None
?                              ^^^
+         x: "f32[2, 4]" = l_x_.add(l_y_);  l_x_ = None
?                              ^^^^^    +
- 
          hints_wrapper_body_1 = self.hints_wrapper_body_1
          hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_1, (x, l_y_), {}, hints = {'outer_body': True});  hints_wrapper_body_1 = x = l_y_ = None
          getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None
          return (getitem,)
  
      class hints_wrapper_body_1(torch.nn.Module):
          def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
              hints_wrapper_body_0 = self.hints_wrapper_body_0
              hints_wrapper = torch.ops.higher_order.hints_wrapper(hints_wrapper_body_0, (x, l_y_), {}, hints = {'inner_body': True});  hints_wrapper_body_0 = x = l_y_ = None
              getitem: "f32[2, 4]" = hints_wrapper[0];  hints_wrapper = None
  
              x_1: "f32[2, 4]" = torch.abs(getitem);  getitem = None
              return (x_1,)
  
          class hints_wrapper_body_0(torch.nn.Module):
              def forward(self, x: "f32[2, 4]", l_y_: "f32[4]"):
                  x_1: "f32[2, 4]" = torch.relu(x);  x = None
  
                  x_2: "f32[2, 4]" = x_1 + l_y_;  x_1 = l_y_ = None
                  return (x_2,)
 : To accept the new output, re-run test with envvar EXPECTTEST_ACCEPT=1 (we recommend staging/committing your changes before doing this)

To execute this test, run the following from the base repo dir:
    python test/dynamo/test_higher_order_ops.py HigherOrderOpTestsWithCompiledAutograd.test_hints_wrapper

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
</details>

Test file path: inductor/test_compiled_autograd.py

For all disabled tests (by GitHub issue), see https://hud.pytorch.org/disabled.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - 💡(How to fix) Fix DISABLED test_hints_wrapper (__main__.HigherOrderOpTestsWithCompiledAutograd)