Issue Station
Sign In
Tools hereToolbox

pytorch - 💡(How to fix) Fix DISABLED test_memory_stats (__main__.TestCuda)

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…

Error Message

Traceback (most recent call last): File "/var/lib/jenkins/workspace/test/test_cuda.py", line 405, in test_memory_stats self.assertEqual(torch.accelerator.max_memory_reserved(), prev_max_reserved) File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 4441, in assertEqual raise error_metas.pop()[0].to_error( # type: ignore[index] AssertionError: Scalars are not equal!

Expected 251658240 but got 253755392. Absolute difference: 2097152 Relative difference: 0.008333333333333333

To execute this test, run the following from the base repo dir: python test/test_cuda.py TestCuda.test_memory_stats

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Root Cause

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Code Example

Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/test_cuda.py", line 405, in test_memory_stats
    self.assertEqual(torch.accelerator.max_memory_reserved(), prev_max_reserved)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 4441, in assertEqual
    raise error_metas.pop()[0].to_error(  # type: ignore[index]
AssertionError: Scalars are not equal!

Expected 251658240 but got 253755392.
Absolute difference: 2097152
Relative difference: 0.008333333333333333

To execute this test, run the following from the base repo dir:
    python test/test_cuda.py TestCuda.test_memory_stats

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
RAW_BUFFERClick to expand / collapse

Platforms: linux, slow

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 6 hours, it has been determined flaky in 3 workflow(s) with 6 failures and 3 successes.

Debugging instructions (after clicking on the recent samples link): DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs. To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_memory_stats
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary> 
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/test_cuda.py", line 405, in test_memory_stats
    self.assertEqual(torch.accelerator.max_memory_reserved(), prev_max_reserved)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 4441, in assertEqual
    raise error_metas.pop()[0].to_error(  # type: ignore[index]
AssertionError: Scalars are not equal!

Expected 251658240 but got 253755392.
Absolute difference: 2097152
Relative difference: 0.008333333333333333

To execute this test, run the following from the base repo dir:
    python test/test_cuda.py TestCuda.test_memory_stats

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
</details>

Test file path: test_cuda.py

For all disabled tests (by GitHub issue), see https://hud.pytorch.org/disabled.

cc @ptrblck @msaroufim @eqy @jerryzh168 @tinglvv @nWEIdia

extent analysis

TL;DR

The most likely fix for the failing test test_memory_stats is to investigate and adjust the memory reservation assertions in the test to account for the small absolute difference of 2097152.

Guidance

  • Investigate the test_memory_stats function in test_cuda.py to understand why the torch.accelerator.max_memory_reserved() value is not matching the expected value of 251658240.
  • Verify the test failure by running the test locally using the command python test/test_cuda.py TestCuda.test_memory_stats and checking the output.
  • Check the workflow logs for any patterns or clues that might indicate why the test is flaky, by following the provided debugging instructions.
  • Consider relaxing the assertion in the test to allow for a small margin of error, given the relative difference is only 0.008333333333333333.

Example

# Example of how to relax the assertion
self.assertAlmostEqual(torch.accelerator.max_memory_reserved(), prev_max_reserved, delta=2097152)

Notes

The provided error message and debugging instructions suggest that the issue is related to the test's assertions, but the root cause of the flakiness is still unknown. Further investigation is needed to determine why the torch.accelerator.max_memory_reserved() value is not consistent.

Recommendation

Apply workaround: Relax the assertion in the test to allow for a small margin of error, as the relative difference is small and the test is currently disabled due to flakiness.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…
#optimization#mixed precision#training loop#device allocation#model download

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING