pytorch - ✅(Solved) Fix DISABLED test_rocm_addmm_aten_bias_input_is_1d (__main__.TestMaxAutotune) [1 pull requests, 1 comments, 2 participants]

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
GitHub stats
pytorch/pytorch#180031Fetched 2026-04-11 06:09:39
View on GitHub
Comments
1
Participants
2
Timeline
84
Reactions
0
Author
Timeline (top)
mentioned ×38subscribed ×38labeled ×7commented ×1

Root Cause

This test was disabled because it is failing on main branch (recent examples).

PR fix notes

PR #180285: [ROCm][inductor][UT] Allow 1D bias_addmm candidate generation

Description (problem / solution / changelog)

Fixes #180031 Fixes #179967

This follows up on #179087 and the original regression from #177130. #178929 updated tuned_addmm to inspect the original ROCm bias input, but bias_addmm still only stayed eligible when that bias looked like the expanded stride-0 form. #179087 then updated the ROCm bias_addmm heuristic to accept a native 1D bias input, but tuned_addmm could still silently drop bias_addmm before the heuristic ran. This change keeps bias_addmm eligible when ROCm addmm autotuning sees a native 1D bias input so max-autotune can still consider the fused bias path instead of silently dropping that choice.

Made with Cursor

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @pragupta @jerrymannil @xinyazhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @mlazos

Changed files

  • torch/_inductor/kernel/mm.py (modified, +7/-2)
RAW_BUFFERClick to expand / collapse

Platforms: rocm

This test was disabled because it is failing on main branch (recent examples).

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @jataylo @hongxiayang @naromero77amd @jerrymannil @xinyazhang @mruberry @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @aakhundov @coconutruben

extent analysis

TL;DR

The test test_rocm_addmm_aten_bias_input_is_1d in test_max_autotune.py needs to be investigated and potentially updated to fix the failure on the main branch.

Guidance

  • Investigate the recent failures on torch-ci.com to understand the error messages and stack traces.
  • Review the test case test_rocm_addmm_aten_bias_input_is_1d in test_max_autotune.py to identify potential issues with the test or the code being tested.
  • Check the ROCm platform configuration and version to ensure it is compatible with the test.
  • Consider re-enabling the test and running it locally to reproduce and debug the issue.

Notes

The issue lacks specific details about the error messages or stack traces, making it difficult to provide a more targeted fix.

Recommendation

Apply workaround: Investigate and update the test case to fix the failure, as the issue seems to be specific to the test_rocm_addmm_aten_bias_input_is_1d test.

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING

pytorch - ✅(Solved) Fix DISABLED test_rocm_addmm_aten_bias_input_is_1d (__main__.TestMaxAutotune) [1 pull requests, 1 comments, 2 participants]