PR #73608: fix(discord): deduplicate accounts sharing the same bot token

• Repository: openclaw/openclaw
• Author: kagura-agent
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/73608

Description (problem / solution / changelog)

Bug

Fixes #73441

Discord DM messages are processed twice when two accounts resolve to the same bot token. The user sends one message but receives two responses.

Root Cause

resolveDiscordToken() has a fallback chain: account-level token → top-level channels.discord.token → DISCORD_BOT_TOKEN env var (for the default account only).

The OpenClaw service manager injects DISCORD_BOT_TOKEN as a managed env var. If a user has a named account (e.g. work) with an explicit token and a default account entry with no configured token, the default account silently picks up the same bot token via the env var fallback.

Both accounts pass the startup filter (enabled && hasToken), so two independent monitors connect to Discord with the same bot credentials. Each monitor has its own replay guard, so both claim the same inbound message:

1. Monitor A processes the message normally → agent replies
2. Monitor B also receives it, but the agent is now busy → message gets enqueued as [Queued messages while agent was busy]
3. Agent finishes → followup queue drains → agent replies again

Fix

Add deduplicateDiscordAccountsByToken() that groups resolved accounts by token value and keeps only one per unique token. When duplicates exist, the account with source: "config" (explicit config) is preferred over source: "env" (env var fallback). A warning is logged when deduplication occurs.

Applied in two places:

• listEnabledDiscordAccounts() — affects monitor startup
• resolveDiscordStartupDelayMs() — affects staggered startup timing

Workaround

Users hitting this today can remove the redundant account entry:

openclaw config unset channels.discord.accounts.default
openclaw gateway restart

Tests

4 new tests covering:

• Config-sourced account kept over env-sourced when tokens match
• Both accounts kept when tokens differ
• First account kept when same token and same source
• Empty-token accounts not deduplicated

Changed files

• extensions/discord/src/accounts.test.ts (modified, +56/-1)
• extensions/discord/src/accounts.ts (modified, +39/-1)
• extensions/discord/src/channel.ts (modified, +10/-7)