PR #84188: Preserve disabled Discord presentation buttons

• Repository: openclaw/openclaw
• Author: 100menotu001
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/84188

Description (problem / solution / changelog)

Summary

Accepts disabled on portable presentation buttons, advertises Discord disabled-button support during channel adaptation, and preserves the field in Discord presentation button specs.

Motivation

Closes #84183.

The runtime type already included disabled, and Discord button specs support disabled buttons, but the message tool schema and Discord presentation mapper dropped the field. The channel capabilities also failed to advertise disabled-button support, so outbound adaptation could strip the state before rendering.

Change Type

• Bug fix

Scope

• Adds disabled to the message tool presentation button schema.
• Copies disabled: true into Discord button specs for presentation and legacy interactive button mapping.
• Sets Discord presentationCapabilities.limits.actions.supportsDisabled to true.
• Adds regression coverage for the adapted outbound path and Discord render output.

Linked Issue/PR

Closes #84183.

Real Behavior Proof

Behavior or issue addressed: A portable presentation button with disabled: true must survive Discord capability adaptation and render as a disabled Discord component, including URL/link buttons.

Real environment tested: Redacted OpenClaw development checkout on this PR branch, using the Discord outbound adapter and Discord presentation renderer.

Exact steps or command run after this patch: Ran a runtime diagnostic against this branch that read Discord presentation capabilities, adapted a disabled URL presentation button for the Discord target runtime, rendered it into a Discord component spec, and serialized the final link button component.

Evidence after fix: Redacted runtime output:

{
  "supportsDisabled": true,
  "adaptedButton": {
    "label": "Open docs",
    "url": "https://example.com/docs",
    "disabled": true
  },
  "componentSpecButton": {
    "label": "Open docs",
    "style": "link",
    "url": "https://example.com/docs",
    "disabled": true
  },
  "serializedLinkButton": {
    "type": 2,
    "style": 5,
    "label": "Open docs",
    "disabled": true,
    "url": "https://example.com/docs"
  },
  "registeredEntries": 0
}

Observed result after fix: Discord advertises disabled-button support, the adapted URL button still has disabled: true, the component spec keeps disabled: true, and final serialized Discord link-button output includes disabled: true.

Not tested: No live Discord provider send was needed for this deterministic capability-adaptation, component-rendering, and final serialization path.

Additional non-link runtime proof from the same branch:

{
  "supportsDisabled": true,
  "adaptedButton": {
    "label": "Already handled",
    "value": "done",
    "disabled": true
  },
  "renderedButton": {
    "label": "Already handled",
    "style": "secondary",
    "callbackData": "done",
    "disabled": true
  }
}

Root Cause

The portable button type and low-level Discord builder already supported disabled buttons, but the schema, adapter capability metadata, and mapping layer did not consistently propagate that field.

Regression Test Plan

• node scripts/run-vitest.mjs extensions/discord/src/shared-interactive.test.ts extensions/discord/src/outbound-adapter.test.ts extensions/discord/src/components.test.ts extensions/discord/src/send.components.test.ts

Result: 4 files passed, 58 tests passed.

User-visible / Behavior Changes

Callers can send disabled Discord presentation buttons through the message tool without falling back to Discord-specific payloads.

Diagram

N/A. This is a field propagation and capability-advertisement fix.

Security Impact

No new secrets or external calls. The change reduces accidental action availability by preserving an explicit disabled state.

Repro + Verification

Before this change, disabled: true could be rejected or dropped before Discord rendering, and disabled URL buttons could survive adaptation but serialize as enabled link buttons. The new regression tests verify that channel adaptation keeps disabled callback and URL buttons, and final Discord link-button serialization emits a disabled component.

Evidence

• Focused regression command passed.
• Redacted runtime diagnostic above confirms supportsDisabled is advertised and disabled: true reaches final serialized Discord link-button output.

Human Verification

No live Discord service is required for this deterministic channel-adaptation and rendering path.

Compatibility / Migration

Backward compatible. Existing messages render the same unless they set disabled: true.

Risks

Low. Only true values are propagated.

Changed files

• extensions/discord/src/components.builders.ts (modified, +1/-0)
• extensions/discord/src/components.test.ts (modified, +36/-1)
• extensions/discord/src/outbound-adapter.test.ts (modified, +51/-0)
• extensions/discord/src/outbound-adapter.ts (modified, +1/-0)
• extensions/discord/src/shared-interactive.test.ts (modified, +36/-0)
• extensions/discord/src/shared-interactive.ts (modified, +6/-0)
• src/agents/tools/message-tool.ts (modified, +1/-0)

PR #84312: Preserve disabled Discord presentation buttons

• Repository: openclaw/openclaw
• Author: clawsweeper[bot]
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/84312

Description (problem / solution / changelog)

Makes https://github.com/openclaw/openclaw/pull/84188 merge-ready for the ClawSweeper automerge loop. The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

• Cluster: automerge-openclaw-openclaw-84188
• Source PRs: https://github.com/openclaw/openclaw/pull/84188
• Credit: Source PR: https://github.com/openclaw/openclaw/pull/84188
• Validation: pnpm check:changed
• Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
• Automerge requested by: @Takhoffman

• Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR: Closes #84183

Co-author credit kept:

• @100menotu001: Co-authored-by: 100menotu001 [email protected]

fish notes: model gpt-5.5, reasoning high; reviewed against f01328f7911f.

Changed files

• CHANGELOG.md (modified, +1/-0)
• extensions/discord/src/components.builders.ts (modified, +1/-0)
• extensions/discord/src/components.test.ts (modified, +36/-1)
• extensions/discord/src/outbound-adapter.test.ts (modified, +51/-0)
• extensions/discord/src/outbound-adapter.ts (modified, +1/-0)
• extensions/discord/src/shared-interactive.test.ts (modified, +36/-0)
• extensions/discord/src/shared-interactive.ts (modified, +6/-0)
• src/agents/tools/message-tool.ts (modified, +1/-0)