PR #24974: fix(cli): restore file path display in edit and write tool confirmations

• Repository: google-gemini/gemini-cli
• Author: jwhelangoog
• State: closed | merged: True
• Link: https://github.com/google-gemini/gemini-cli/pull/24974

Description (problem / solution / changelog)

Summary

This PR fixes a UI regression where the target file path was missing from the Edit and WriteFile tool confirmation prompts.

Details

PR #24376 introduced a new UI layout for tool confirmations but suppressed the tool.description for tools using the edit confirmation type. Since Edit and WriteFile rely on their tool description to communicate the target file path (e.g., ✓ Edit src/main.ts), this suppression caused only the generic tool name to be displayed, hiding crucial context from the user.

This change removes the !isEdit restriction in ToolConfirmationQueue.tsx, restoring the description visibility for edit tool confirmations.

Related Issues

Fixes #24936

How to Validate

1. Start the CLI and run a command that triggers an edit, e.g., "Add a comment to the top of packages/cli/src/nonInteractiveCli.ts".
2. When prompted for confirmation, verify that the header displays the tool description, which includes the file path (e.g., ? Edit packages/cli/src/nonInteractiveCli.ts).
3. This should also work similarly for the WriteFile tool when creating a new file.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

Changed files

• packages/cli/src/ui/__snapshots__/ToolConfirmationFullFrame-Full-Terminal-Tool-Confirmation-Snapshot-renders-tool-confirmation-box-in-the-frame-of-the-entire-terminal.snap.svg (modified, +2/-1)
• packages/cli/src/ui/__snapshots__/ToolConfirmationFullFrame.test.tsx.snap (modified, +1/-1)
• packages/cli/src/ui/components/ToolConfirmationQueue.test.tsx (modified, +38/-0)
• packages/cli/src/ui/components/ToolConfirmationQueue.tsx (modified, +2/-2)
• packages/cli/src/ui/components/__snapshots__/ToolConfirmationQueue-ToolConfirmationQueue-height-allocation-and-layout-should-render-the-full-queue-wrapper-with-borders-and-content-for-large-edit-diffs.snap.svg (modified, +2/-1)
• packages/cli/src/ui/components/__snapshots__/ToolConfirmationQueue.test.tsx.snap (modified, +3/-3)
• packages/cli/src/ui/components/messages/DenseToolMessage.test.tsx (modified, +22/-0)