litellm - ✅(Solved) Fix [Feature]: Helm chart better migration job annotations control [1 pull requests, 1 comments, 2 participants]

litellm2026-04-30 09:12:32

ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

GitHub issue URL

Helpful · Quick feedback

GitHub stats

BerriAI/litellm#26875•Fetched 2026-05-01 05:34:40

View on GitHub

Comments

Participants

Timeline

Reactions

Author

beli-sk

Participants

beli-sk

littlesvensson

Timeline (top)

commented ×1cross-referenced ×1labeled ×1

Fix Action

Fixed

Fixed by PR: feat(helm): helm chart: migration job annotation control (https://github.com/BerriAI/litellm/pull/26881)

PR fix notes

PR #26881: feat(helm): helm chart: migration job annotation control

Repository: BerriAI/litellm
Author: beli-sk
State: open | merged: False
Link: https://github.com/BerriAI/litellm/pull/26881

Description (problem / solution / changelog)

Feature (Helm chart)

Allow the Helm chart user better control of the annotations of the migrations job, like changing the ArgoCD or Helm hook stage (PreSync, Sync, etc.) or adding custom annotations.

Following optional values added:

migrationJob:
  jobAnnotations: {}
  hooks:
    argocd:
      hook: PreSync
      hookDeletePolicy: BeforeHookCreation
    helm:
      hook: pre-install,pre-upgrade
      hookDeletePolicy: before-hook-creation

Relevant issues

Fixes #26875

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I have Added testing in the tests/test_litellm/ directory, Adding at least 1 test is a hard requirement - see details
My PR passes all unit tests on make test-unit
My PR's scope is as isolated as possible, it only solves 1 specific problem
I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

CI (LiteLLM team)

CI status guideline:

50-55 passing tests: main is stable with minor issues.

45-49 passing tests: acceptable but needs attention

<= 40 passing tests: unstable; be careful with your merges and assess the risk.

Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:

Screenshots / Proof of Fix

Type

🚄 Infrastructure

Changes

Changed files

deploy/charts/litellm-helm/templates/migrations-job.yaml (modified, +7/-4)
deploy/charts/litellm-helm/tests/migrations-job_tests.yaml (modified, +32/-0)
deploy/charts/litellm-helm/values.yaml (modified, +9/-0)

RAW_BUFFERClick to expand / collapse

Check for existing issues

I have searched the existing issues and checked that my issue is not a duplicate.

The Feature

Please allow the Helm chart user better control of the annotations of the migrations job, like changing the ArgoCD or Helm hook stage (PreSync, Sync, etc.) or adding custom annotations. They are important for managing the ordering and lifecycle of the migrations job in a custom deployment context.

Motivation, pitch

Helm chart migrations job annotations are currently very rigid, only providing to run in a specific ArgoCD or Helm hook sync stage, without allowing the user to override them.

This can lead to problems for example when using custom database deployment and needing to sequence the job after the database is synced, otherwise the hook job will run in ArgoCD PreSync stage, blocking the progression of the deployment before the database can be deployed in the Sync stage.

Will try to propose a MR.

What part of LiteLLM is this about?

Other

LiteLLM is hiring a founding backend engineer, are you interested in joining us and shipping to all our users?

Twitter / LinkedIn details

No response

extent analysis

TL;DR

Allowing users to customize annotations for the migrations job in the Helm chart can be achieved by introducing configurable parameters for ArgoCD or Helm hook stages and custom annotations.

Guidance

Introduce a new value in the Helm chart's values.yaml file to allow users to specify the desired hook stage (e.g., PreSync, Sync) for the migrations job.
Add a separate value for custom annotations, enabling users to provide additional annotations as needed.
Update the Helm chart's template to incorporate these new values, using them to set the appropriate annotations for the migrations job.
Document the new configuration options in the Helm chart's README to inform users about the available customization possibilities.

Example

# values.yaml
migrations:
  hookStage: Sync
  customAnnotations:
    example.com/annotation: "custom-value"

Notes

The proposed solution assumes that the Helm chart is designed to work with ArgoCD and that the migrations job is currently hardcoded to run in a specific hook stage. The introduction of configurable parameters will provide users with more control over the deployment process.

Recommendation

Apply workaround by introducing configurable parameters for the hook stage and custom annotations, as this will provide the necessary flexibility for users to manage the ordering and lifecycle of the migrations job in custom deployment contexts.

Vote matrix · Quick signals

Works

Did the solution work? Tap to confirm.

Easy Fix

Was it a quick fix?

Time Saver

Did it save you time?

Blocking

Was it severely blocking?

Common Issue

Are others likely hitting this too?

Flaky / Intermittent

Is it intermittent?

Verified / Reproducible

Can you reproduce it reliably?

#cache error #pipeline error #runtime error #dependency conflict #environment setup

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.