openclaw - 💡(How to fix) Fix [Feature]: Smart proxy detection - fallback to direct connection when proxy unavailable [1 participants]

TL;DR

Modify the resolveProxyUri() function in gaxios-fetch-compat.ts to check if the proxy port is reachable before using it, falling back to a direct connection if the proxy is closed.

Guidance

• Implement the proposed isProxyReachable() function to attempt a TCP connection to the proxy address, returning undefined if the connection fails.
• Modify resolveProxyUri() to utilize the isProxyReachable() function, conditionally returning the proxy URI or undefined based on the proxy's reachability.
• Consider handling potential exceptions or errors that may occur during the TCP connection attempt in isProxyReachable().
• Test the modified resolveProxyUri() function with various proxy states (open and closed) to verify its correctness.

Example

function isProxyReachable(proxyAddress: string): boolean {
  const [host, port] = proxyAddress.split(':');
  const socket = require('net').createConnection({ host, port });
  return new Promise((resolve) => {
    socket.once('connect', () => {
      socket.destroy();
      resolve(true);
    });
    socket.once('error', () => {
      resolve(false);
    });
  });
}

function resolveProxyUri(proxyAddress: string): string | undefined {
  return isProxyReachable(proxyAddress).then((reachable) => {
    return reachable ? proxyAddress : undefined;
  });
}

Notes

The proposed solution assumes that the isProxyReachable() function will correctly determine the reachability of the proxy port. However, this approach may introduce additional latency due to the TCP connection attempt. Consider implementing a caching mechanism or a more efficient reachability check if performance becomes a concern.

Recommendation

Apply the proposed workaround by modifying the resolveProxyUri() function to check for proxy reachability, as this approach directly addresses the issue and provides a fallback for when the proxy is closed.