PR #57806: Signal quote reply

• Repository: openclaw/openclaw
• Author: pritchie
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/57806

Description (problem / solution / changelog)

Summary

Describe the problem and fix in 2–5 bullets:

• Problem: Signal quoted replies were only used as a fallback body, so quote id/author context was dropped before hooks saw the message, as a result OpenClaw could not see quote replies. This PR adds that feature.
• What changed: Signal inbound handling now maps quote metadata into MsgContext, hook mappers forward that reply metadata into plugin/internal hook events, and the Signal inbound-context test was rewritten to mock heavy seams before import so the coverage actually runs.
• This PR depends on running signal-cli 0.13.14 or greater. I explicitly didn't couple verifying that is present with this PR, but can do so in a follow-up PR. I have a draft of doing it in Doctor but ran into test timeout hell with doctor-install.ts tests.
• The tests I (via Codex) wrote are also heavily mocked due to timeout issues. Happy to discuss trade-offs / adjust.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Integrations
• API / contracts
• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• UI / DX
• CI/CD / infra

Linked Issue/PR

• Closes #
• Related #
• This PR fixes a bug or regression

Root Cause / Regression History (if applicable)

• Root cause: extensions/signal/src/monitor/event-handler.ts only treated dataMessage.quote.text as a body fallback and never mapped quote id/author into finalized inbound context; src/hooks/message-hook-mappers.ts also did not forward reply metadata into plugin/internal hook events.
• Missing detection / guardrail: no Signal hook-path test asserted ReplyTo* propagation end-to-end, and the old inbound-context test was heavy enough to stall on import.
• Prior context (git blame, prior PR, issue, or refactor if known): long-standing omission in Signal inbound context plus generic hook canonicalization; not tied to a known recent refactor.
• Why this regressed now: not a recent regression, more an exposed gap once reply-aware hook consumers needed quote context.
• If unknown, what was ruled out: N/A

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
  • Seam / integration test
  • End-to-end test
  • Existing coverage already sufficient
• Target test or file: extensions/signal/src/monitor/event-handler.inbound-context.test.ts and src/auto-reply/reply/dispatch-from-config.test.ts
• Scenario the test should lock in: a quoted Signal inbound message populates ReplyToId, ReplyToBody, ReplyToSender, and ReplyToIsQuote in MsgContext, and hook metadata preserves those fields.
• Why this is the smallest reliable guardrail: it covers Signal parsing, finalized inbound context, and hook mapping without needing a live Signal daemon.
• Existing test that already covers this (if any): src/auto-reply/reply/dispatch-from-config.test.ts now covers reply metadata on hook emission once the inbound context includes it.
• If no new test is added, why not: N/A

User-visible / Behavior Changes

• Signal inbound hook consumers now receive quoted-reply metadata in hook payloads: replyToId, replyToBody, replyToSender, and replyToIsQuote.
• No config, env, or default behavior changes.
• Test-only change: the focused Signal inbound-context test no longer stalls on import.

Diagram (if applicable)

Before:
Signal quoted reply -> quote text maybe used as fallback body -> hook metadata loses reply context

After:
Signal quoted reply -> MsgContext ReplyTo* fields -> canonical hook context -> plugin/internal hooks receive reply metadata

Security Impact (required)

• New permissions/capabilities? (No)
• Secrets/tokens handling changed? (No)
• New/changed network calls? (No)
• Command/tool execution surface changed? (No)
• Data access scope changed? (No)
• If any Yes, explain risk + mitigation: N/A

Repro + Verification

Environment

• OS: tested Linux & macOS
• Runtime/container: Node 24 + pnpm + Vitest
• Model/provider: gpt 5.4
• Integration/channel (if any): Signal
• Relevant config (redacted): synthetic Signal receive envelope via test harness; default Signal test deps with quoted reply payload

Steps

1. From main or latest release, quote reply in Signal, and ask the OpenClaw to play it back.

Expected

• OpenClaw can see the quoted message.

Actual

• OpenClaw cannot see the quoted message.

Evidence

Attach at least one:

• Failing test/log before + passing after
• Trace/log snippets
• Screenshot/recording
• Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

• Verified scenarios: quoted Signal replies can be played back by OpenClaw assertions still pass; hook metadata propagation is covered in src/auto-reply/reply/dispatch-from-config.test.ts.
• Edge cases checked: quote id normalization to string, quote author fallback ordering, and no import-time hang in the focused Signal test.
• What you did not verify: live Signal daemon roundtrip or third-party plugin end-to-end hook consumption.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? (Yes)
• Config/env changes? (No)
• Migration needed? (No)
• If yes, exact upgrade steps: N/A

Risks and Mitigations

• Risk: reply metadata is now present in hook payloads where some plugin consumers may have assumed it was absent.
  • Mitigation: the fields are additive and optional, so existing consumers can ignore them safely.
• Risk: the new test uses aggressive pre-import mocks and could drift from runtime behavior.
  • Mitigation: the assertions stay focused on externally observable handler behavior, and pnpm check plus the targeted Signal test remain green.

Changed files

• extensions/signal/src/monitor/event-handler.inbound-context.test.ts (modified, +455/-9)
• extensions/signal/src/monitor/event-handler.ts (modified, +24/-9)
• extensions/signal/src/monitor/event-handler.types.ts (modified, +9/-1)
• extensions/signal/src/monitor/inbound-context.ts (modified, +13/-3)
• src/auto-reply/reply/dispatch-from-config.test.ts (modified, +18/-0)
• src/hooks/message-hook-mappers.ts (modified, +20/-0)