openclaw - 💡(How to fix) Fix feishu: fetchQuotedMessage JSON parse error crashes entire message dispatch [1 participants]

When a user quotes a Feishu message that contains malformed card JSON (e.g. from a previous bot reply with invalid card content), fetchQuotedMessage throws a SyntaxError that is not caught. This exception propagates up and aborts the entire message dispatch pipeline, leaving the session stuck until the user sends a new message to re-activate it. elog.warn(feishu[${accountId}]: failed to parse quoted message card JSON, skipping quoted context, e.message);

TL;DR

Wrap the JSON parsing in fetchQuotedMessage with a try-catch block to catch and handle SyntaxError exceptions, preventing the message dispatch pipeline from aborting.

Guidance

• Identify the fetchQuotedMessage function and modify it to include a try-catch block around the JSON parsing code.
• In the catch block, log a warning message with the error details and set the quotedContent to null or a raw text fallback to allow message dispatch to continue.
• Verify that the modified function correctly handles malformed JSON content and does not abort the message dispatch pipeline.
• Test the fix with different types of malformed JSON content to ensure it works as expected.

Example

try {
  quotedContent = JSON.parse(rawCardContent);
} catch (e) {
  console.warn(`Failed to parse quoted message card JSON, skipping quoted context: ${e.message}`);
  quotedContent = null; // or fallback to raw text
}

Notes

This fix assumes that the fetchQuotedMessage function is the only place where JSON parsing is done, and that wrapping it with a try-catch block will prevent the SyntaxError exception from propagating up and aborting the message dispatch pipeline.

Recommendation

Apply the suggested fix to wrap the JSON parsing in fetchQuotedMessage with a try-catch block, as it directly addresses the root cause of the issue and prevents the message dispatch pipeline from aborting.