PR #23405: fix(cron): use POSIX paths for bash scripts on native Windows

• Repository: NousResearch/hermes-agent
• Author: CalmProton
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23405

Description (problem / solution / changelog)

Summary

On native Windows with Git Bash, .sh / .bash cron scripts always fail because bash interprets backslashes in the path argument as escape sequences, mangling C:\Users\... into C:Users... (exit code 127, script not found).

This PR gates a one-line fix behind os.name == "nt": use path.as_posix() to produce forward-slash paths (/c/Users/...) that MSYS2 bash understands natively. Non-Windows platforms are completely unaffected — they continue to use str(path).

How to Test

1. On native Windows with Git Bash, create a cron job with no_agent: true and a .sh script
2. Confirm the script runs successfully instead of failing with exit code 127

Or use the existing test suite:

python -m pytest tests/cron/test_cron_no_agent.py -v

The test test_run_job_script_shell_script_runs_via_bash already exercises this code path and passes both before and after the change (the test uses POSIX paths, so the fix is invisible to it — as intended).

Platform Tested

• OS: Windows 11 (native, git-bash)
• Python: 3.11.14
• Hermes: v0.13.0

Pre-submit checks

• scripts/check-windows-footguns.py — zero footguns found
• tests/cron/test_cron_no_agent.py — all 18 tests pass

Related

Closes #23404

Changed files

• cron/scheduler.py (modified, +10/-1)

PR #23489: fix(cron): normalize bash script paths on Windows

• Repository: NousResearch/hermes-agent
• Author: LeonSGP43
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/23489

Description (problem / solution / changelog)

What does this PR do?

Fixes native Windows Git Bash cron .sh / .bash script execution by normalizing the script argument to a forward-slash path before invoking bash.

Without this, _run_job_script() passes a native Windows path like C:\Users\denis\.hermes\scripts\hermes-backup.sh, and Git Bash treats the backslashes as escape characters, mangling the path into C:Usersdenis... and failing with exit code 127.

Related Issue

Fixes #23404

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 🔒 Security fix
• 📝 Documentation update
• ✅ Tests (adding or improving test coverage)
• ♻️ Refactor (no behavior change)
• 🎯 New skill (bundled or hub)

Changes Made

• Added _format_bash_script_path() in /cron/scheduler.py to centralize bash path formatting.
• Switched .sh / .bash execution in _run_job_script() to use a bash-safe path argument on Windows.
• Added regression tests in /tests/cron/test_scheduler.py for Windows and POSIX path formatting behavior.

How to Test

1. Run uv run --frozen pytest -q -o addopts='' tests/cron/test_scheduler.py
2. Run uv run --frozen ruff check cron/scheduler.py tests/cron/test_scheduler.py
3. On native Windows with Git Bash, configure a cron job using a .sh script and verify the script path reaches bash in forward-slash form instead of losing backslashes.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS (targeted regression tests); Windows path behavior covered by explicit unit tests

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — or N/A
• I've updated cli-config.yaml.example if I added/changed config keys — or N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
• I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

• uv run --frozen pytest -q -o addopts='' tests/cron/test_scheduler.py -> 123 passed
• uv run --frozen ruff check cron/scheduler.py tests/cron/test_scheduler.py -> All checks passed!
• The repo-wide local pytest tests/ -q entrypoint still fails during collection on both this branch and a clean origin/main worktree with the same preexisting environment-level errors (tomllib, acp, websockets.asyncio, StrEnum), so I left that checklist item unchecked rather than claiming a false full-green run.

Changed files

• cron/scheduler.py (modified, +9/-2)
• tests/cron/test_scheduler.py (modified, +20/-1)