openclaw - 💡(How to fix) Fix fix(edit tool): edits[] format with unicode fails with misleading 'Missing required parameters' error [1 comments, 2 participants]

Summary

The edit tool fails with Missing required parameters: oldText alias, newText alias when called with the native pi-coding-agent edits: [{oldText, newText}] array format. This is especially reproducible — and consistent — when oldText or newText contain unicode characters (em dashes U+2014, smart quotes, etc.), because those can also break JSON schema validation of the edits[] items, making edits come through as undefined.

Root Cause

createHostWorkspaceEditTool and createSandboxedEditTool in src/agents/pi-tools.read.ts wrap the underlying edit tool with:

wrapToolParamNormalization(tool, CLAUDE_PARAM_GROUPS.edit)

CLAUDE_PARAM_GROUPS.edit validates that flat top-level oldText/newText params are present. But Claude Sonnet 4.x sends the pi-coding-agent native format — edits: [{oldText, newText}] — not flat params. The validation fires unconditionally before the tool executes, producing a misleading error instead of the correct "Could not find the exact text in..." message from the underlying tool.

Additionally, the wrapper strips the base tool's prepareArguments hook, so the backward-compat flat→array conversion in edit.js::prepareEditArguments never runs.

Reproduction

Call the edit tool with:

{
  "path": "some/file.ts",
  "edits": [{"oldText": "text with \u2014 em dash", "newText": "replacement"}]
}

Result: Missing required parameters: oldText alias, newText alias
Expected: Successful edit (or Could not find the exact text in... if text not found)

Fix

Add wrapEditToolParamNormalization to src/agents/pi-tools.read.ts:

export function wrapEditToolParamNormalization(tool: AnyAgentTool): AnyAgentTool {
  const patched = patchToolSchemaForClaudeCompatibility(tool);
  return {
    ...patched,
    execute: async (toolCallId, params, signal, onUpdate) => {
      const normalized = normalizeToolParams(params);
      const record =
        normalized ??
        (params && typeof params === "object" ? (params as Record<string, unknown>) : undefined);
      // Skip flat-param validation when the native edits[] format is present.
      // The underlying tool validates edits[] with clear messages ("Could not find...").
      const hasEditsArray =
        record != null &&
        Array.isArray((record as Record<string, unknown>).edits) &&
        ((record as Record<string, unknown>).edits as unknown[]).length > 0;
      if (!hasEditsArray) {
        assertRequiredParams(record, CLAUDE_PARAM_GROUPS.edit, tool.name);
      }
      return tool.execute(toolCallId, normalized ?? params, signal, onUpdate);
    },
  };
}

Then use it in createSandboxedEditTool and createHostWorkspaceEditTool instead of wrapToolParamNormalization(_, CLAUDE_PARAM_GROUPS.edit).

Affected files

• src/agents/pi-tools.read.ts

Notes

• Backward compat preserved: flat {path, oldText, newText} format still works (falls through to the legacy validation path when edits[] is absent)
• No changes needed to pi-tools.params.ts or the underlying @mariozechner/pi-coding-agent package
• Verified fix works with Claude Sonnet 4.6 with em dashes (U+2014) and smart quotes in oldText
• The CLAUDE_PARAM_GROUPS.edit validator was written for the legacy flat format; the pi-coding-agent has used edits[] natively for a while