codex - 💡(How to fix) Fix fix: unified_exec yield_time_ms behaves as floor instead of ceiling [1 comments, 2 participants]

TL;DR

Modify the collect_output_until_deadline loop in process_manager.rs to break as soon as output is available, treating yield_time_ms as a maximum wait time instead of a minimum.

Guidance

• Review the proposed fix in the codex-1#fix/yield-time-ceiling diff to understand the specific code changes required.
• Verify the fix by running the added test unified_exec_yield_time_is_ceiling_not_floor, which should pass if the issue is resolved.
• Consider the impact on existing code that relies on the current behavior, as fast shell commands will now return instantly instead of blocking for the full yield timeout.
• Test the fix with various shell commands and yield timeouts to ensure it works as expected in different scenarios.

Example

The proposed fix involves changing the loop condition in collect_output_until_deadline to:

if !collected.is_empty() {
    break;
}

This change allows the loop to exit as soon as output is available, rather than waiting for the full timeout.

Notes

The fix assumes that the collected variable is correctly updated when output is available. If this is not the case, additional changes may be needed to ensure the loop exits correctly.

Recommendation

Apply the proposed workaround by modifying the collect_output_until_deadline loop as described, as it correctly treats yield_time_ms as a maximum wait time and allows fast shell commands to return instantly.