Bug Description

tests/gateway/test_agent_cache.py::TestAgentCacheIdleResume::test_close_vs_release_full_teardown_difference fails on main because the test monkeypatches tools.terminal_tool.cleanup_vm, but AIAgent.close() calls the cleanup_vm symbol imported into run_agent.py at module import time.

Affected files/lines

• tests/gateway/test_agent_cache.py:972-986 patches _tt.cleanup_vm and expects agent_b.close() to append "hard-session".
• run_agent.py:73 imports cleanup_vm directly: from tools.terminal_tool import cleanup_vm, ....
• run_agent.py:3977-3980 calls the imported cleanup_vm(task_id) symbol inside AIAgent.close().

Why this is a bug

The regression test is intended to pin the resource-lifecycle contract that release_clients() is soft eviction while close() performs hard teardown. However, it currently patches the wrong binding, so the test fails even though close() does call its local imported cleanup_vm symbol. This leaves the teardown contract test broken/noisy and can mask real regressions in agent-cache cleanup behavior.

Minimal reproduction

From repo root with the venv active:

/Users/genie/.hermes/hermes-agent/venv/bin/python -m pytest tests/gateway/test_agent_cache.py::TestAgentCacheIdleResume::test_close_vs_release_full_teardown_difference -q

Observed failure:

E       AssertionError: assert 'hard-session' in []

Narrow binding check:

from run_agent import AIAgent
import run_agent
from tools import terminal_tool as _tt

vm=[]
orig_ra=run_agent.cleanup_vm
orig_tt=_tt.cleanup_vm
try:
    _tt.cleanup_vm = lambda tid: vm.append(('tt', tid))
    a = AIAgent(..., session_id='hard-session')
    a.close()
    assert vm == []  # test's current patch target misses run_agent.cleanup_vm
finally:
    _tt.cleanup_vm = orig_tt
    run_agent.cleanup_vm = orig_ra

vm=[]
try:
    run_agent.cleanup_vm = lambda tid: vm.append(('run_agent', tid))
    a = AIAgent(..., session_id='hard-session')
    a.close()
    assert vm == [('run_agent', 'hard-session')]
finally:
    run_agent.cleanup_vm = orig_ra

Expected vs actual

• Expected: the test should patch the symbol actually used by AIAgent.close() and pass when close() performs hard teardown but release_clients() does not.
• Actual: the test patches tools.terminal_tool.cleanup_vm; run_agent.cleanup_vm remains bound to the original function, so vm_calls stays empty and the test fails.

Suggested investigation direction

Patch run_agent.cleanup_vm in this test (prefer monkeypatch.setattr(run_agent, "cleanup_vm", ...)) instead of mutating tools.terminal_tool.cleanup_vm. Consider similarly checking whether cleanup_browser/process-registry teardown assertions patch the exact imported symbol when they are testing AIAgent.close().