PR #75172: fix(gateway): guard against undefined channelLogs entry in async channel lifecycle handlers

• Repository: openclaw/openclaw
• Author: hclsys
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/75172

Description (problem / solution / changelog)

Summary

Fixes #75168.

Root cause: channelLogs[channelId] can be evicted from the map during a config-reload race while a promise chain from a prior startChannelInternal call is still in flight. The existing log.error?.() guards protected against a missing .error method on the logger object, but not against log itself being undefined — resulting in TypeError: Cannot read properties of undefined (reading 'error') and a gateway crash.

Fix: Capture log as SubsystemLogger | undefined at task start, then apply optional-chain guards (log?.error?.(), log?.info?.()) on all six async continuation call sites inside startChannelInternal. This matches the existing pattern already used at line 699 (channelLogs[plugin.id]?.error?.()).

Changes

• src/gateway/server-channels.ts: cast log as potentially undefined; update 6 async call sites from log.X?.() to log?.X?.()
• src/gateway/server-channels.test.ts: regression test using a Proxy-backed channelLogs map that returns undefined after a flag is set, confirming no TypeError when .catch() and backoff-restart handlers fire without a live logger

Test plan

• pnpm vitest run src/gateway/server-channels.test.ts — 26/26 pass (includes new regression test)
• New test: Proxy-backed channelLogs evicts entry mid-run; vi.advanceTimersByTimeAsync(50) must resolve without throwing

🤖 Generated with Claude Code

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/gateway/server-channels.test.ts (modified, +29/-0)
• src/gateway/server-channels.ts (modified, +11/-7)
• src/gateway/server.impl.ts (modified, +8/-0)

PR #75331: fix(gateway/server-channels): guard against undefined channel logger (#75168)

• Repository: openclaw/openclaw
• Author: jhsmith409
• State: closed | merged: False
• Link: https://github.com/openclaw/openclaw/pull/75331

Description (problem / solution / changelog)

Summary

Fixes #75168.

The channel auto-restart promise chain in createChannelManager reads the per-channel logger via const log = channelLogs[channelId]. The type is Record<ChannelId, SubsystemLogger>, so TypeScript treats log as non-nullable, but at runtime the lookup can return undefined if a channel plugin's id was registered without a corresponding channelLogs entry (race between plugin registration and logger attachment). When the channel's startup task then exits or errors, the .catch / .then handlers call log.error?.(...) — and the optional chain only guards the function call, not the property access.

Result: TypeError: Cannot read properties of undefined (reading 'error') surfacing as an unhandled rejection that crashes the gateway every ~5 minutes under launchd KeepAlive: true (reported against feishu/whatsapp on v2026.4.27).

Changes

src/gateway/server-channels.ts — switch every log.<level>?.(...) access in the affected closures to log?.<level>?.(...). Six call sites (lines 407, 484, 518, 523, 545, 549, 663). The same safe-access pattern is already used at line 699 (channelLogs[plugin.id]?.error?.(...)).

-            log.error?.(`[${id}] ${label}: ${formatErrorMessage(error)}`);
+            log?.error?.(`[${id}] ${label}: ${formatErrorMessage(error)}`);

src/gateway/server-channels.test.ts — regression test that spins up the channel manager with an intentionally-empty channelLogs map and asserts that a startAccount failure is captured into the runtime snapshot's lastError rather than escaping as an unhandled rejection.

Verified

• Without the fix, the new test fails on the assertion expect(unhandledRejection).not.toHaveBeenCalled() (the TypeError escapes).
• With the fix, all 26 tests in src/gateway/server-channels.test.ts pass.
• Repo tsgo --noEmit reports unrelated pre-existing errors in src/agents/pi-embedded-runner/run/attempt.test.ts and src/agents/pi-embedded-runner.sanitize-session-history.test.ts — confirmed they exist on a clean upstream main without my change.

Notes

• I left the typed params.log.X?.(...) calls in src/gateway/exec-approval-ios-push.ts alone — that one's log is typed as required GatewayLikeLogger and isn't pulled out of the racing channelLogs map. Not the same bug shape.
• Module-scoped const log = createSubsystemLogger(...) in channel-health-monitor.ts likewise can't be undefined and was left untouched.

Changed files

• src/gateway/server-channels.test.ts (modified, +37/-0)
• src/gateway/server-channels.ts (modified, +7/-7)